aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #2141 from whitequark/cxxrtl-cxx11whitequark2020-06-103-8/+10
|\ | | | | cxxrtl: various compiler compatibility fixes
| * cxxrtl: restore C++11 compatibility.whitequark2020-06-101-1/+2
| | | | | | | | This is necessary to be able to build CXXRTL models via yosys-config.
| * cxxrtl: fix a few gcc warnings.whitequark2020-06-101-5/+6
| |
| * Fix formatting. NFC.whitequark2020-06-101-2/+2
| |
* | Merge pull request #2140 from whitequark/cxxrtl-aliaseswhitequark2020-06-104-9/+50
|\ \ | |/ |/| cxxrtl: disambiguate values/wires and their aliases in debug info
| * cxxrtl: disambiguate values/wires and their aliases in debug info.whitequark2020-06-104-9/+50
|/ | | | | | | With this change, it is easier to see which signals carry state (only wire<>s appear as `reg` in VCD files) and to construct a minimal checkpoint (CXXRTL_WIRE debug items represent the canonical smallest set of state required to fully reconstruct the simulation).
* Merge pull request #2134 from whitequark/cxxrtl-opt-debugwhitequark2020-06-101-52/+105
|\ | | | | cxxrtl: introduce -Og optimization level
| * cxxrtl: allow unbuffering without localizing.whitequark2020-06-091-40/+74
| | | | | | | | | | | | | | Although logically two separate steps, these were treated as one for historic reasons. Splitting the two makes it possible to have designs that are only 2× slower than fastest possible (and are without extra delta cycles) that allow probing all public wires.
| * cxxrtl: order -On levels as localize, elide instead of the reverse.whitequark2020-06-091-8/+8
| | | | | | | | | | | | | | | | | | | | | | Historically, elision was implemented before localization, so levels with elision are lower than corresponding levels with localization. This is unfortunate for two reasons: 1. Elision is a logical subset of localization, since it equals to not giving a name to a temporary. 2. "Localize" currently actually means "unbuffer and localize", and it would be useful to split those steps (at least for public wires) for improved design visibility.
| * cxxrtl: factor out -noproc/-noflatten from -O.whitequark2020-06-091-17/+36
| | | | | | | | | | | | | | | | Although these options can be thought of as optimizations, they are essentially orthogonal to the core of -O, which is managing signal buffering and scope. Going from -O4 to -O2 means going from limited to complete design visibility, yet in both cases proc and flatten are desirable.
* | Merge pull request #2131 from YosysHQ/claire/preserveffsclairexen2020-06-106-33/+50
|\ \ | | | | | | Do not optimize away FFs in "prep" and Verific front-end
| * | Fix tests/opt/opt_rmdffClaire Wolf2020-06-092-22/+29
| | | | | | | | | | | | | | | | | | This only passed before because "prep" was also running opt_rmdff Signed-off-by: Claire Wolf <claire@symbioticeda.com>
| * | Drive-by modernization in sat.ccClaire Wolf2020-06-091-4/+4
| | | | | | | | | | | | Signed-off-by: Claire Wolf <claire@symbioticeda.com>
| * | Do not optimize away FFs in "prep" and Verific fron-endClaire Wolf2020-06-093-7/+17
| |/ | | | | | | Signed-off-by: Claire Wolf <claire@symbioticeda.com>
* | Merge pull request #2139 from YosysHQ/verific_missing_memoryclairexen2020-06-101-2/+7
|\ \ | | | | | | verific - detect missing memory to prevent crash.
| * | verific - detect missing memory to prevent crash.Miodrag Milanovic2020-06-101-2/+7
|/ /
* | Merge pull request #2112 from YosysHQ/claire/fix2040clairexen2020-06-092-0/+58
|\ \ | |/ |/| Add latch detection for use_case_method in part-select write
| * Add latch detection for use_case_method in part-select write, fixes #2040Claire Wolf2020-06-042-0/+58
| | | | | | | | Signed-off-by: Claire Wolf <claire@symbioticeda.com>
* | Merge pull request #2128 from whitequark/flatten-processeswhitequark2020-06-093-10/+20
|\ \ | | | | | | flatten: accept processes
| * | flatten: accept processes.whitequark2020-06-091-8/+8
| | |
| * | RTLIL: add Module::addProcess, use it in Module::cloneInto. NFC.whitequark2020-06-092-2/+12
| | |
* | | Merge pull request #2130 from whitequark/cxxrtl-fix-split_bywhitequark2020-06-092-14/+16
|\ \ \ | |/ / |/| | cxxrtl: fix two buggy split_by functions
| * | cxxrtl: fix two buggy split_by functions.whitequark2020-06-092-14/+16
|/ /
* | Merge pull request #2126 from whitequark/cxxrtl-non-ext-logic-opswhitequark2020-06-092-64/+35
|\ \ | | | | | | cxxrtl: ignore cell input signedness when it is irrelevant
| * | cxxrtl: ignore cell input signedness when it is irrelevant.whitequark2020-06-092-64/+35
| | | | | | | | | | | | | | | | | | | | | | | | Before this commit, Verilog expressions like `x && 1` would result in references to `logic_and_us` in generated CXXRTL code, which would not compile. After this commit, since cells like that actually behave the same regardless of signedness attributes, the signedness is ignored, which also reduces the template instantiation pressure.
* | | Merge pull request #2125 from whitequark/cxxrtl-fix-namespacewhitequark2020-06-091-2/+2
|\ \ \ | |/ / |/| | cxxrtl: add missing namespace
| * | cxxrtl: add missing namespace.whitequark2020-06-091-2/+2
|/ / | | | | | | Fixes #2124.
* | Merge pull request #2107 from whitequark/flatten-hdlnamewhitequark2020-06-096-11/+54
|\ \ | | | | | | flatten: preserve original object names
| * | cxxrtl: fix format of hdlnames.whitequark2020-06-081-1/+1
| | | | | | | | | | | | | | | The CXXRTL code that handled the `hdlname` attribute implemented outdated semantics.
| * | flatten: preserve original object names via hdlname attribute.whitequark2020-06-085-6/+45
| | |
| * | flatten: only prepend $flatten once per wire.whitequark2020-06-081-2/+6
| | |
| * | RTLIL: use {get,set}_string_attribute in {get,set}_strpool_attribute.whitequark2020-06-081-2/+2
|/ / | | | | | | | | The only difference in behavior is that this removes the attribute when the pool becomes empty.
* | Merge pull request #2120 from whitequark/flatten-hygienewhitequark2020-06-081-155/+116
|\ \ | | | | | | flatten: make hygienic
| * | flatten: make hygienic.whitequark2020-06-081-155/+116
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this commit, `flatten` matched the template objects with the newly created objects solely by their name. Because of this, it could be confused by code such as: module bar(); $dff a(); endmodule module foo(); bar b(); $dff \b.a (); endmodule After this commit, `flatten` avoids every possible case of name collision. Fixes #2106.
* | Merge pull request #2121 from whitequark/cxxrtl-debug-aliaseswhitequark2020-06-085-25/+120
|\ \ | | | | | | cxxrtl: improve design visibility
| * | cxxrtl: don't check immutable values for changes in VCD writer.whitequark2020-06-081-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes the VCD writer such that for all signals that have `debug_item.type == VALUE && debug_item.next == nullptr`, it would only sample the value once. Commit f2d7a187 added more debug information by including constant wires, and decreased the performance of VCD writer proportionally because the constant wires were still repeatedly sampled; this commit eliminates the performance hit.
| * | cxxrtl: emit debug information for constant wires.whitequark2020-06-083-17/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | Constant wires can represent a significant chunk of the design in generic designs or after optimization. Emitting them in VCD files significantly improves usability because gtkwave removes all traces that are not present in the VCD file after reload, and iterative development suffers if switching a varying signal to a constant disrupts the workflow.
| * | cxxrtl: track aliases in VCD writer.whitequark2020-06-081-10/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes the VCD writer such that for all signals that share `debug_item.curr`, it would only emit a single VCD identifier, and sample the value once. Commit 9b39c6f7 added redundancy to debug information by including alias wires, and increased the size of VCD files proportionally; this commit eliminates the redundancy from VCD files so that their size is the same as before.
| * | cxxrtl: emit debug information for alias wires.whitequark2020-06-081-3/+55
| | | | | | | | | | | | | | | | | | | | | Alias wires can represent a significant chunk of the design in highly hierarchical designs; in Minerva SRAM, there are 273 member wires and 527 alias wires. Showing them in every hierarchy level significantly improves usability.
| * | cxxrtl: add missing installs of include files.whitequark2020-06-081-0/+5
| | |
| * | cxxrtl: fix typo in comment. NFC.whitequark2020-06-081-4/+4
| | |
| * | cxxrtl: minor debug-related improvements.whitequark2020-06-081-2/+3
| | |
* | | Merge pull request #2085 from rswarbrick/selectclairexen2020-06-082-15/+20
|\ \ \ | | | | | | | | Silence warning in select.cc and pass some more args by ref
| * | | Pass some more args by reference in select.ccRupert Swarbrick2020-05-272-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this patch, the code passed around std::string objects by value. It's probably not a hot-spot, but it can't hurt to avoid the copying. Removing the copy and clean-up code means the resulting code is ~6.1kb smaller when compiled with GCC 9.3 and standard settings.
| * | | Minor optimisations in select.cc's match_ids functionRupert Swarbrick2020-05-271-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Pass a string argument by reference - Avoid multiple calls to IdString::str and IdString::c_str - Avoid combining checks for size > 0 and first char (C strings are null terminated, so foo[0] != '\0' implies that foo has positive length)
| * | | Silence warning in select.ccRupert Swarbrick2020-05-271-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With GCC 9.3, at least, compiling select.cc spits out a warning about an implausible bound being passed to strncmp. This comes from inlining IdString::compare(): it turns out that passing std::string::npos as a bound to strncmp triggers it. This patch replaces the compare call with a memcmp with the same effect. The repeated calls to IdString::c_str are slightly inefficient, but I'll address that in a follow-up commit.
* | | | Merge pull request #2089 from rswarbrick/modportsclairexen2020-06-081-13/+6
|\ \ \ \ | | | | | | | | | | Simplify a modport check in hierarchy.cc
| * | | | Simplify a modport check in hierarchy.ccRupert Swarbrick2020-05-261-13/+6
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This code originally comes from commit 458a940. When an interface is used via a modport, code in genrtlil.cc sets '\\interface_type' and '\\interface_modport' properties on the wire. In hierarchy.cc, we pick up the modport name and add it to a dict called modports_used_in_submodule (that maps connection source to modport name). Before this patch, the modport name is retrieved as a strpool and then iterated over in an arbitrary order, discarding all entries but the last. In practice, the pool will always have 0 or 1 entries because the string used to construct it is a valid identifier, so doesn't contain any pipe symbols. This patch changes the code to retrieve the modport name as just a string. This will have the same effect in practice, but may be a bit less confusing! The code also gets moved down closer to where the result is used, which might be a bit more efficient since we won't always get as far as the check. The patch also removes some commented-out code, which I think was intended to add some typechecking at some point, but was never implemented. Since this dates back to October 2018, I think it makes more sense to just take it out.
* | | | Merge pull request #2105 from whitequark/split-flatten-off-techmapclairexen2020-06-085-325/+541
|\ \ \ \ | | | | | | | | | | Split `flatten` from `techmap` and simplify it
| * | | | flatten: clean up log messages.whitequark2020-06-041-1/+1
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-19 16:15:29 +0000