aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorwhitequark <whitequark@whitequark.org>2020-12-23 23:15:56 +0000
committerGitHub <noreply@github.com>2020-12-23 23:15:56 +0000
commitdeff6a9546699da5fc37e2fba622862daa120fd8 (patch)
tree0c8eb479613490bf66ac1efa1b765045c494837a
parent8ef6b77dc366563410c88ec3687f777e74685377 (diff)
parent999eec561752706a8ccb085a692684c745415985 (diff)
downloadyosys-deff6a9546699da5fc37e2fba622862daa120fd8.tar.gz
yosys-deff6a9546699da5fc37e2fba622862daa120fd8.tar.bz2
yosys-deff6a9546699da5fc37e2fba622862daa120fd8.zip
Merge pull request #2501 from zachjs/genrtlil-tern-sign
genrtlil: fix mux2rtlil generated wire signedness
-rw-r--r--frontends/ast/genrtlil.cc1
-rw-r--r--tests/various/port_sign_extend.v13
2 files changed, 10 insertions, 4 deletions
diff --git a/frontends/ast/genrtlil.cc b/frontends/ast/genrtlil.cc
index 500ccf8c0..b8bfdf65e 100644
--- a/frontends/ast/genrtlil.cc
+++ b/frontends/ast/genrtlil.cc
@@ -141,6 +141,7 @@ static RTLIL::SigSpec mux2rtlil(AstNode *that, const RTLIL::SigSpec &cond, const
RTLIL::Wire *wire = current_module->addWire(cell->name.str() + "_Y", left.size());
wire->attributes[ID::src] = stringf("%s:%d.%d-%d.%d", that->filename.c_str(), that->location.first_line, that->location.first_column, that->location.last_line, that->location.last_column);
+ wire->is_signed = that->is_signed;
for (auto &attr : that->attributes) {
if (attr.second->type != AST_CONSTANT)
diff --git a/tests/various/port_sign_extend.v b/tests/various/port_sign_extend.v
index 055f20ad8..446268268 100644
--- a/tests/various/port_sign_extend.v
+++ b/tests/various/port_sign_extend.v
@@ -24,8 +24,8 @@ module PassThrough(a, b);
assign b = a;
endmodule
-module act(o1, o2, o3, o4, o5, yay1, nay1, yay2, nay2);
- output wire [3:0] o1, o2, o3, o4, o5;
+module act(o1, o2, o3, o4, o5, o6, yay1, nay1, yay2, nay2);
+ output wire [3:0] o1, o2, o3, o4, o5, o6;
// unsigned constant
PassThrough pt1(1'b1, o1);
@@ -48,6 +48,10 @@ module act(o1, o2, o3, o4, o5, yay1, nay1, yay2, nay2);
wire signed [1:0] tmp5b = 2'b01;
PassThrough pt5(tmp5a ^ tmp5b, o5);
+ wire signed [2:0] tmp6a = 3'b100;
+ wire signed [2:0] tmp6b = 3'b001;
+ PassThrough pt6(tmp6a ? tmp6a : tmp6b, o6);
+
output wire [2:0] yay1, nay1;
GeneratorSigned1 os1(yay1);
GeneratorUnsigned1 ou1(nay1);
@@ -57,14 +61,15 @@ module act(o1, o2, o3, o4, o5, yay1, nay1, yay2, nay2);
GeneratorUnsigned2 ou2(nay2);
endmodule
-module ref(o1, o2, o3, o4, o5, yay1, nay1, yay2, nay2);
- output wire [3:0] o1, o2, o3, o4, o5;
+module ref(o1, o2, o3, o4, o5, o6, yay1, nay1, yay2, nay2);
+ output wire [3:0] o1, o2, o3, o4, o5, o6;
assign o1 = 4'b0001;
assign o2 = 4'b0001;
assign o3 = 4'b1111;
assign o4 = 4'b1111;
assign o5 = 4'b1110;
+ assign o6 = 4'b1100;
output wire [2:0] yay1, nay1;
assign yay1 = 3'b111;