1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
|
From ec29b05b2da1d82d03730e0ac317efd3a7e97759 Mon Sep 17 00:00:00 2001
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
Date: Thu, 15 Apr 2021 17:30:35 +0100
Subject: [PATCH] drm/panel: jdi-lt070me05000: Use
gpiod_set_value_cansleep
There is no reason why the control GPIOs for the panel can not
be connected to I2C or similar GPIO interfaces that may need to
sleep, therefore switch from gpiod_set_value to
gpiod_set_value_cansleep calls to configure them.
Without that you get complaints from gpiolib every time the state
is changed.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
--- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
+++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
@@ -205,11 +205,11 @@ static int jdi_panel_unprepare(struct dr
if (ret < 0)
dev_err(dev, "regulator disable failed, %d\n", ret);
- gpiod_set_value(jdi->enable_gpio, 0);
+ gpiod_set_value_cansleep(jdi->enable_gpio, 0);
- gpiod_set_value(jdi->reset_gpio, 1);
+ gpiod_set_value_cansleep(jdi->reset_gpio, 1);
- gpiod_set_value(jdi->dcdc_en_gpio, 0);
+ gpiod_set_value_cansleep(jdi->dcdc_en_gpio, 0);
jdi->prepared = false;
@@ -233,13 +233,13 @@ static int jdi_panel_prepare(struct drm_
msleep(20);
- gpiod_set_value(jdi->dcdc_en_gpio, 1);
+ gpiod_set_value_cansleep(jdi->dcdc_en_gpio, 1);
usleep_range(10, 20);
- gpiod_set_value(jdi->reset_gpio, 0);
+ gpiod_set_value_cansleep(jdi->reset_gpio, 0);
usleep_range(10, 20);
- gpiod_set_value(jdi->enable_gpio, 1);
+ gpiod_set_value_cansleep(jdi->enable_gpio, 1);
usleep_range(10, 20);
ret = jdi_panel_init(jdi);
@@ -263,11 +263,11 @@ poweroff:
if (ret < 0)
dev_err(dev, "regulator disable failed, %d\n", ret);
- gpiod_set_value(jdi->enable_gpio, 0);
+ gpiod_set_value_cansleep(jdi->enable_gpio, 0);
- gpiod_set_value(jdi->reset_gpio, 1);
+ gpiod_set_value_cansleep(jdi->reset_gpio, 1);
- gpiod_set_value(jdi->dcdc_en_gpio, 0);
+ gpiod_set_value_cansleep(jdi->dcdc_en_gpio, 0);
return ret;
}
|
