diff options
| author | Koen Vandeputte <koen.vandeputte@ncentric.com> | 2018-11-08 12:46:37 +0100 |
|---|---|---|
| committer | Koen Vandeputte <koen.vandeputte@ncentric.com> | 2018-11-08 13:32:22 +0100 |
| commit | b4e17a7440cd9885a678f2a28609a38eca6dd5dc (patch) | |
| tree | fb2c016cd6ea6849f3f46604b5278ac5d223854a /target/linux/ramips | |
| parent | d157a76c67bcb821d3ec8dcd4312390ef129a95a (diff) | |
| download | upstream-b4e17a7440cd9885a678f2a28609a38eca6dd5dc.tar.gz upstream-b4e17a7440cd9885a678f2a28609a38eca6dd5dc.tar.bz2 upstream-b4e17a7440cd9885a678f2a28609a38eca6dd5dc.zip | |
ramips: fix netgear r6120 factory image generation
as indicated in commit c5bf408ed6bd "(ramips: fix image generation for mt76x8")
more rework was needed to fix the other issues.
Building on another machine, but using the same arch, showed
the application failing again for different reasons.
Fix this by completely rewriting the application, fixing following found issues:
- buffer overflows, resulting in stack corruption
- flaws in memory requirement calculations (too small, too large)
- memory leaks
- missing bounds checking on string handling
- non-reproducable images, by using unitilized memory in checksum calculation
- missing error handling, resulting in succes on specific image errors
- endianness errors when building on BE machines
- various minor build warnings
- documentation did not match the code actions (header item locations)
- allowing input to be decimal, hex or octal now
Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
Diffstat (limited to 'target/linux/ramips')
| -rw-r--r-- | target/linux/ramips/image/mt76x8.mk | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/target/linux/ramips/image/mt76x8.mk b/target/linux/ramips/image/mt76x8.mk index 15bc1ee703..16fbad2bbc 100644 --- a/target/linux/ramips/image/mt76x8.mk +++ b/target/linux/ramips/image/mt76x8.mk @@ -115,10 +115,10 @@ define Device/netgear_r6120 IMAGE_SIZE := $(ralink_default_fw_size_16M) DEVICE_TITLE := Netgear AC1200 R6120 DEVICE_PACKAGES := kmod-usb2 kmod-usb-ohci - SERCOMM_KERNEL_OFFSET := 90000 + SERCOMM_KERNEL_OFFSET := 0x90000 SERCOMM_HWID := CGQ SERCOMM_HWVER := A001 - SERCOMM_SWVER := 0040 + SERCOMM_SWVER := 0x0040 IMAGES += factory.img IMAGE/default := append-kernel | pad-to $$$$(BLOCKSIZE)| append-rootfs | pad-rootfs IMAGE/sysupgrade.bin := $$(IMAGE/default) | append-metadata | check-size $$$$(IMAGE_SIZE) |