diff options
| author | Austin Seipp <aseipp@pobox.com> | 2022-01-04 10:49:54 -0600 |
|---|---|---|
| committer | Marcelina Kościelnicka <mwk@0x04.net> | 2022-01-04 18:18:08 +0100 |
| commit | b022fe61a7e0cbe93124a5db243083e65f51fd85 (patch) | |
| tree | 24f42af92cace7939a5ed19db66a9425cae96f9b | |
| parent | 493b5e03e7ce9496980c9235bb2979bd259995a6 (diff) | |
| download | yosys-b022fe61a7e0cbe93124a5db243083e65f51fd85.tar.gz yosys-b022fe61a7e0cbe93124a5db243083e65f51fd85.tar.bz2 yosys-b022fe61a7e0cbe93124a5db243083e65f51fd85.zip | |
opt_dff: fix sequence point copy paste bug
Newer GCCs emit the following warning for opt_dff:
passes/opt/opt_dff.cc:560:17: warning: operation on ‘ff.Yosys::FfData::has_clk’ may be undefined [-Wsequence-point]
560 | ff.has_clk = ff.has_ce = ff.has_clk = false;
| ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Which is correct: the order of whether the read or write of has_clk
occurs first is undefined since there is no sequence point between them.
This is almost certainly just a typo/copy paste error and objectively
wrong, so just fix it.
Signed-off-by: Austin Seipp <aseipp@pobox.com>
| -rw-r--r-- | passes/opt/opt_dff.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/passes/opt/opt_dff.cc b/passes/opt/opt_dff.cc index 38faba15a..98b66dee3 100644 --- a/passes/opt/opt_dff.cc +++ b/passes/opt/opt_dff.cc @@ -557,7 +557,7 @@ struct OptDffWorker // The D input path is effectively useless, so remove it (this will be a const-input D latch, SR latch, or a const driver). log("Handling D = Q on %s (%s) from module %s (removing D path).\n", log_id(cell), log_id(cell->type), log_id(module)); - ff.has_clk = ff.has_ce = ff.has_clk = false; + ff.has_clk = ff.has_ce = false; changed = true; } } |