diff options
author | Nico Huber <nico.h@gmx.de> | 2021-05-11 17:53:34 +0200 |
---|---|---|
committer | Nico Huber <nico.h@gmx.de> | 2021-05-13 14:37:43 +0000 |
commit | 90739d147f1d9b90789873fdbe74da6c616cad6b (patch) | |
tree | 019d727f7b3289a0d71c831374e2f33c3ae1b66a /it85spi.c | |
parent | 7e4968525d37d87e8b6f8b848e4f2f9696926237 (diff) | |
download | flashrom-90739d147f1d9b90789873fdbe74da6c616cad6b.tar.gz flashrom-90739d147f1d9b90789873fdbe74da6c616cad6b.tar.bz2 flashrom-90739d147f1d9b90789873fdbe74da6c616cad6b.zip |
programmer: Make use of new register_spi_master() API
Pass pointers to dynamically allocated data to register_spi_master().
This way we can avoid some mutable globals.
Change-Id: Id7821f1db3284b7b5b3d0abfd878b979c53870a1
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/54067
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'it85spi.c')
-rw-r--r-- | it85spi.c | 6 |
1 files changed, 2 insertions, 4 deletions
@@ -281,7 +281,7 @@ static int it85xx_spi_send_command(const struct flashctx *flash, return 0; } -static struct spi_master spi_master_it85xx = { +static const struct spi_master spi_master_it85xx = { .max_data_read = 64, .max_data_write = 64, .command = it85xx_spi_send_command, @@ -358,15 +358,13 @@ int it85xx_spi_init(struct superio s) return 1; } - spi_master_it85xx.data = data; - /* FIXME: Really leave FWH enabled? We can't use this region * anymore since accessing it would mess up IT85 communication. * If we decide to disable FWH for this region, we should print * a debug message about it. */ /* Set this as SPI controller. */ - register_spi_master(&spi_master_it85xx, NULL); + register_spi_master(&spi_master_it85xx, data); return 0; } |