diff options
| author | Nico Huber <nico.huber@secunet.com> | 2017-03-29 16:44:33 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2017-07-28 12:24:06 +0000 |
| commit | 0bb3f7142aecdf883cc28bd9b771bdba3da5d7d9 (patch) | |
| tree | 1bd56eecff210a628c148c836e2dfce13ebfd5f8 /ichspi.c | |
| parent | d54e4f467753a247552bfb629f007f8931b0caa7 (diff) | |
| download | flashrom-0bb3f7142aecdf883cc28bd9b771bdba3da5d7d9.tar.gz flashrom-0bb3f7142aecdf883cc28bd9b771bdba3da5d7d9.tar.bz2 flashrom-0bb3f7142aecdf883cc28bd9b771bdba3da5d7d9.zip | |
ich_descriptors: Draw +0xfff into ICH_FREG_LIMIT()
The condition `base > limit` is still valid since `base` is always at
least 4096 greater than `limit` in this case.
Change-Id: I11ac0a50b3f32f47879e7cfb7a26068cd0572ede
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/19046
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'ichspi.c')
| -rw-r--r-- | ichspi.c | 8 |
1 files changed, 3 insertions, 5 deletions
@@ -1566,14 +1566,12 @@ static int ich9_handle_frap(uint32_t frap, int i) msg_pdbg("0x%02X: 0x%08x ", offset, freg); if (rwperms == 0x3) { msg_pdbg("FREG%i: %s region (0x%08x-0x%08x) is %s.\n", i, - region_name, base, (limit | 0x0fff), - access_names[rwperms]); + region_name, base, limit, access_names[rwperms]); return 0; } msg_pwarn("FREG%i: Warning: %s region (0x%08x-0x%08x) is %s.\n", i, - region_name, base, (limit | 0x0fff), - access_names[rwperms]); + region_name, base, limit, access_names[rwperms]); return 1; } @@ -1608,7 +1606,7 @@ static int ich9_handle_pr(const size_t reg_pr0, int i) msg_pdbg("0x%02X: 0x%08x ", off, pr); msg_pwarn("%sPR%u: Warning: 0x%08x-0x%08x is %s.\n", prefix, i, ICH_FREG_BASE(pr), - ICH_FREG_LIMIT(pr) | 0x0fff, access_names[rwperms]); + ICH_FREG_LIMIT(pr), access_names[rwperms]); return 1; } |