diff options
author | Shiyu Sun <sshiyu@google.com> | 2021-01-21 16:08:11 +1100 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2021-02-12 13:14:54 +0000 |
commit | 6cad608483924cd9c0c0c201ae69ee7e513a0f9e (patch) | |
tree | a9d4bc2da94e341b963c7766d1f2b1d67e91abc3 /coreboot_tables.h | |
parent | 32aa933b1da48b0730dd79fbb15d864643391072 (diff) | |
download | flashrom-6cad608483924cd9c0c0c201ae69ee7e513a0f9e.tar.gz flashrom-6cad608483924cd9c0c0c201ae69ee7e513a0f9e.tar.bz2 flashrom-6cad608483924cd9c0c0c201ae69ee7e513a0f9e.zip |
realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function
Gpio 88 toggle is used as write protection disable/enable now
and we need that to happen at the initialization of programmer.
Background:
The RTD devices has an interesting implementation where the
flag we need to flash is `aa aa aa ff ff`. However, after reset,
the boot firmware of RTD device will overwrite this flag value to
`aa aa aa ff aa`. Given this evidence, the root cause would be
that the boot firmware is doing something with protection enable
by itself. This explains why the message
'Block protection cannot be disabled' is shown since the block
protection is called before write operation.
BUG=b:147402710,b:152558985,b:178766553
BRANCH=none
TEST=flashrom -p realtek_mst_i2c_spi:bus=x,reset-mcu=1,enter-isp=1 -w
image.bin
Signed-off-by: Shiyu Sun <sshiyu@chromium.org>
Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1
Reviewed-on: https://review.coreboot.org/c/flashrom/+/49785
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'coreboot_tables.h')
0 files changed, 0 insertions, 0 deletions