diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2006-11-07 11:16:21 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2006-11-07 11:16:21 +0000 |
| commit | 987942dcbdd3f139f2fb0ddcd9593a39bba7ff5b (patch) | |
| tree | 5a790e26089ae597e7ccb4df0ecd50082f9e5ae9 | |
| parent | c6b5f4913b6b4970cbc2f02d1e69964297125946 (diff) | |
| download | flashrom-987942dcbdd3f139f2fb0ddcd9593a39bba7ff5b.tar.gz flashrom-987942dcbdd3f139f2fb0ddcd9593a39bba7ff5b.tar.bz2 flashrom-987942dcbdd3f139f2fb0ddcd9593a39bba7ff5b.zip | |
Fix some code comments of the Intel PIIX4/PIIX4E/PIIX4M code
Add detailed instructions on how and where to get the datasheet,
its name, and order number.
Corresponding to flashrom svn r70 and coreboot v2 svn r2493.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
| -rw-r--r-- | flash_enable.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/flash_enable.c b/flash_enable.c index dd53f0eb..901144ca 100644 --- a/flash_enable.c +++ b/flash_enable.c @@ -77,7 +77,12 @@ static int enable_flash_sis630(struct pci_dev *dev, char *name) return 0; } -/* Datasheet: http://www.intel.com/design/intarch/datashts/290562.htm */ +/* Datasheet: + * - Name: 82371AB PCI-TO-ISA / IDE XCELERATOR (PIIX4) + * - URL: http://www.intel.com/design/intarch/datashts/290562.htm + * - PDF: http://www.intel.com/design/intarch/datashts/29056201.pdf + * - Order Number: 290562-001 + */ static int enable_flash_piix4(struct pci_dev *dev, char *name) { uint16_t old, new; @@ -90,10 +95,11 @@ static int enable_flash_piix4(struct pci_dev *dev, char *name) Set bit 7: Extended BIOS Enable (PCI master accesses to FFF80000-FFFDFFFF are forwarded to ISA). Set bit 6: Lower BIOS Enable (PCI master, or ISA master accesses to - the lower 64-Kbyte BIOS block (E00000EFFFF) at the top + the lower 64-Kbyte BIOS block (E0000-EFFFF) at the top of 1 Mbyte, or the aliases at the top of 4 Gbyte - (FFFE0000-FFFEFFF) result in the generation of BIOSCS#. - Set bit 2: BIOSCS# Write Protect Enable (1=enable, 0=disable). */ + (FFFE0000-FFFEFFFF) result in the generation of BIOSCS#. + Note: Accesses to FFFF0000-FFFFFFFF are always forwarded to ISA. + Set bit 2: BIOSCS# Write Enable (1=enable, 0=disable). */ new = old | 0x2c4; if (new == old) |