aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlan Green <avg@google.com>2019-06-27 16:58:20 +1000
committerEdward O'Callaghan <quasisec@chromium.org>2019-07-04 04:29:26 +0000
commit86bf6ab8876898d93ec19472190d8a2d0d56056e (patch)
tree5001c54868278741c6675e2bf319128d88ef1b6e
parentfdf5da43975808230f4e7c455dd0c57552622dfb (diff)
downloadflashrom-86bf6ab8876898d93ec19472190d8a2d0d56056e.tar.gz
flashrom-86bf6ab8876898d93ec19472190d8a2d0d56056e.tar.bz2
flashrom-86bf6ab8876898d93ec19472190d8a2d0d56056e.zip
flashchips: Drop dead code of AT26DF321
The definition for the AT26DF321 has been commented out since it was first added in 2008. The chip now appears to be obsolete, being marked "obsolete" and unstocked at Digikey. It is also only referred to in historical documents on the manufacturer's website (microchip.com). To avoid further bitrot of this dead code, drop it. Signed-off-by: Alan Green <avg@google.com> Change-Id: Ib30b3a16f25de5def508d90ec9375563b1d4d384 Reviewed-on: https://review.coreboot.org/c/flashrom/+/33836 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
-rw-r--r--flashchips.c20
-rw-r--r--flashchips.h1
2 files changed, 1 insertions, 20 deletions
diff --git a/flashchips.c b/flashchips.c
index f3aab521..ac655104 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -1709,6 +1709,7 @@ const struct flashchip flashchips[] = {
.voltage = {2700, 3600},
},
+ /*The AT26DF321 has the same ID as the AT25DF321. */
{
.vendor = "Atmel",
.name = "AT25DF321",
@@ -2510,25 +2511,6 @@ const struct flashchip flashchips[] = {
.voltage = {2700, 3600},
},
- /*The AT26DF321 has the same ID as the AT25DF321. */
- /*{
- .vendor = "Atmel",
- .name = "AT26DF321",
- .bustype = BUS_SPI,
- .manufacture_id = ATMEL_ID,
- .model_id = ATMEL_AT26DF321,
- .total_size = 4096,
- .page_size = 256,
- .feature_bits = FEATURE_WRSR_WREN,
- .tested = TEST_UNTESTED,
- .probe = probe_spi_rdid,
- .probe_timing = TIMING_ZERO,
- .printlock = spi_prettyprint_status_register_at26df081a,
- .unlock = spi_disable_blockprotect,
- .write = spi_chip_write_256,
- .read = spi_chip_read,
- },*/
-
{
.vendor = "Atmel",
.name = "AT26F004",
diff --git a/flashchips.h b/flashchips.h
index a1b38e0e..1c7ba999 100644
--- a/flashchips.h
+++ b/flashchips.h
@@ -156,7 +156,6 @@
#define ATMEL_AT26DF081A 0x4501
#define ATMEL_AT26DF161 0x4600
#define ATMEL_AT26DF161A 0x4601
-#define ATMEL_AT26DF321 0x4700 /* Same as 25DF321 */
#define ATMEL_AT26F004 0x0400
#define ATMEL_AT29LV512 0x3D
#define ATMEL_AT29LV010A 0x35 /* Same as AT29BV010A, the latter works down to 2.7V */