diff options
| author | Peter Marheine <pmarheine@chromium.org> | 2021-08-04 17:13:42 +1000 |
|---|---|---|
| committer | Edward O'Callaghan <quasisec@chromium.org> | 2021-08-10 02:37:54 +0000 |
| commit | 541f79df447dba7f91a6101766c6b44aaf751075 (patch) | |
| tree | d2b15d314da645bc0820e08690b21b0bd57ca1ff | |
| parent | e0ece4a4bb200ed28859419e5349a38a9b02baf1 (diff) | |
| download | flashrom-541f79df447dba7f91a6101766c6b44aaf751075.tar.gz flashrom-541f79df447dba7f91a6101766c6b44aaf751075.tar.bz2 flashrom-541f79df447dba7f91a6101766c6b44aaf751075.zip | |
realtek_mst_i2c_spi: don't always fail init
In some earlier refactoring the init function for this programmer was
broken such that it never succeeds, since the return value was never set
to a value other than a generic failure. Fix it to return success unless
there is a problem.
TEST=flashrom -p realtek_mst_i2c_spi:bus=n --flash-size now works
when n is a bus that has a connected MST.
Change-Id: I0596014fc9b76b4d11de230f9f5c414c1321dff1
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56799
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | realtek_mst_i2c_spi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index 22f7e7af..a45838cb 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -445,7 +445,7 @@ static int realtek_mst_i2c_spi_shutdown(void *data) static int get_params(int *reset, int *enter_isp) { char *reset_str = NULL, *isp_str = NULL; - int ret = SPI_GENERIC_ERROR; + int ret = 0; reset_str = extract_programmer_param("reset-mcu"); if (reset_str) { |