diff options
author | Anastasia Klimchuk <aklm@chromium.org> | 2021-07-05 16:51:10 +1000 |
---|---|---|
committer | Edward O'Callaghan <quasisec@chromium.org> | 2021-07-23 02:51:05 +0000 |
commit | 19c6b2821dffe212fba9421495c77fe8f5db319e (patch) | |
tree | 4239b11a29e38b24d1b92c2a988f0c313373f8b7 | |
parent | e2c8ecf6e07ceb64871798d01a47ec588b527040 (diff) | |
download | flashrom-19c6b2821dffe212fba9421495c77fe8f5db319e.tar.gz flashrom-19c6b2821dffe212fba9421495c77fe8f5db319e.tar.bz2 flashrom-19c6b2821dffe212fba9421495c77fe8f5db319e.zip |
spi_master: Add default write_aai function to masters that have none
write_aai is required to register a spi master, if it is not set in
spi_master struct then register_spi_master returns ERROR_FLASHROM_BUG.
Masters in this patch did not have it set in the struct, and
register_spi_master always returned an error for them. However return
value of register_spi_master was ignored, so this was hard to notice.
Next patch in the chain checks return value of register_spi_master.
BUG=b:185191942
TEST=builds and ninja test
Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56102
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
-rw-r--r-- | ene_lpc.c | 1 | ||||
-rw-r--r-- | mec1308.c | 1 |
2 files changed, 2 insertions, 0 deletions
@@ -511,6 +511,7 @@ static const struct spi_master spi_master_ene = { .multicommand = default_spi_send_multicommand, .read = default_spi_read, .write_256 = default_spi_write_256, + .write_aai = default_spi_write_aai, }; static int check_params(void) @@ -404,6 +404,7 @@ static const struct spi_master spi_master_mec1308 = { .multicommand = default_spi_send_multicommand, .read = default_spi_read, .write_256 = default_spi_write_256, + .write_aai = default_spi_write_aai, }; static int check_params(void) |