always show revoked user ids last!

1 files changed, 4 insertions, 4 deletions

diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/provider/ProviderHelper.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/provider/ProviderHelper.java
index c3990229d..b2af5a0a0 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/provider/ProviderHelper.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/provider/ProviderHelper.java
@@ -716,6 +716,10 @@ public class ProviderHelper {
 
         @Override
         public int compareTo(UserPacketItem o) {
+            // revoked keys always come last!
+            if (isRevoked != o.isRevoked) {
+                return isRevoked ? 1 : -1;
+            }
             // if one is a user id, but the other isn't, the user id always comes first.
             // we compare for null values here, so != is the correct operator!
             // noinspection NumberEquality
@@ -726,10 +730,6 @@ public class ProviderHelper {
             if (isPrimary != o.isPrimary) {
                 return isPrimary ? -1 : 1;
             }
-            // revoked keys always come last!
-            if (isRevoked != o.isRevoked) {
-                return isRevoked ? 1 : -1;
-            }
             return 0;
         }
     }