diff options
author | Clemens <cle1000.cb@gmail.com> | 2016-08-19 09:23:41 +0200 |
---|---|---|
committer | Clemens <cle1000.cb@gmail.com> | 2016-08-19 09:23:41 +0200 |
commit | d4b18eae8181051f5230b796046cc7ff56e94862 (patch) | |
tree | 41b5b0576871356f74818299da7258872b15eefb | |
parent | 9a86750e9dc2c1fa0010722eb68541aba08c9721 (diff) | |
download | mitmproxy-d4b18eae8181051f5230b796046cc7ff56e94862.tar.gz mitmproxy-d4b18eae8181051f5230b796046cc7ff56e94862.tar.bz2 mitmproxy-d4b18eae8181051f5230b796046cc7ff56e94862.zip |
refactoring
-rw-r--r-- | web/src/js/components/ContentView/UploadContentButton.jsx | 4 | ||||
-rw-r--r-- | web/src/js/components/common/Dropdown.jsx | 2 | ||||
-rw-r--r-- | web/src/js/ducks/ui/flow.js | 3 | ||||
-rw-r--r-- | web/src/js/utils.js | 7 |
4 files changed, 7 insertions, 9 deletions
diff --git a/web/src/js/components/ContentView/UploadContentButton.jsx b/web/src/js/components/ContentView/UploadContentButton.jsx index 6764e234..de349af4 100644 --- a/web/src/js/components/ContentView/UploadContentButton.jsx +++ b/web/src/js/components/ContentView/UploadContentButton.jsx @@ -6,9 +6,7 @@ UploadContentButton.propTypes = { } export default function UploadContentButton({ uploadContent }) { - - let fileInput; - + return ( <FileChooser icon="fa-upload" diff --git a/web/src/js/components/common/Dropdown.jsx b/web/src/js/components/common/Dropdown.jsx index 9db131d4..cc95a6dc 100644 --- a/web/src/js/components/common/Dropdown.jsx +++ b/web/src/js/components/common/Dropdown.jsx @@ -1,7 +1,7 @@ import React, { Component, PropTypes } from 'react' import classnames from 'classnames' -export function Divider () { return <hr className="divider"/>} +export const Divider = () => <hr className="divider"/> export default class Dropdown extends Component { diff --git a/web/src/js/ducks/ui/flow.js b/web/src/js/ducks/ui/flow.js index 22a8c22d..e65c39a3 100644 --- a/web/src/js/ducks/ui/flow.js +++ b/web/src/js/ducks/ui/flow.js @@ -152,6 +152,5 @@ export function setContent(content){ } export function stopEdit(flow, modifiedFlow) { - let diff = getDiff(flow, modifiedFlow) - return flowsActions.update(flow, diff) + return flowsActions.update(flow, getDiff(flow, modifiedFlow)) } diff --git a/web/src/js/utils.js b/web/src/js/utils.js index e44182d0..e8470cec 100644 --- a/web/src/js/utils.js +++ b/web/src/js/utils.js @@ -107,14 +107,15 @@ fetchApi.put = (url, json, options) => fetchApi( ...options } ) - +// deep comparison of two json objects (dicts). arrays are handeled as a single value. +// return: json object including only the changed keys value pairs. export function getDiff(obj1, obj2) { let result = {...obj2}; for(let key in obj1) { if(_.isEqual(obj2[key], obj1[key])) result[key] = undefined - else if(!(Array.isArray(obj2[key]) && Array.isArray(obj1[key])) && - typeof obj2[key] == 'object' && typeof obj1[key] == 'object') + else if(Object.prototype.toString.call(obj2[key]) === '[object Object]' && + Object.prototype.toString.call(obj1[key]) === '[object Object]' ) result[key] = getDiff(obj1[key], obj2[key]) } return result |