diff options
| author | Maximilian Hils <git@maximilianhils.com> | 2018-01-14 21:52:32 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-01-14 21:52:32 +0100 |
| commit | 9a43ff5da107a862169d75fa49fb0d43b172cd3c (patch) | |
| tree | cb6d229aa725d8ee863ae1b8c1f10a1da0aaac4d | |
| parent | 3b5237c55f4ecc30a0f9d0980965490d6e034ad1 (diff) | |
| parent | 2fd9ef4769a5755d1287ce2b096cedd103a12c3f (diff) | |
| download | mitmproxy-9a43ff5da107a862169d75fa49fb0d43b172cd3c.tar.gz mitmproxy-9a43ff5da107a862169d75fa49fb0d43b172cd3c.tar.bz2 mitmproxy-9a43ff5da107a862169d75fa49fb0d43b172cd3c.zip | |
Merge pull request #2793 from kajojify/issue-2399
Issue 2399
| -rw-r--r-- | mitmproxy/net/http/url.py | 2 | ||||
| -rw-r--r-- | test/mitmproxy/net/http/test_url.py | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/mitmproxy/net/http/url.py b/mitmproxy/net/http/url.py index 86f65cfd..f938cb12 100644 --- a/mitmproxy/net/http/url.py +++ b/mitmproxy/net/http/url.py @@ -76,7 +76,7 @@ def encode(s: Sequence[Tuple[str, str]], similar_to: str=None) -> str: encoded = urllib.parse.urlencode(s, False, errors="surrogateescape") - if remove_trailing_equal: + if encoded and remove_trailing_equal: encoded = encoded.replace("=&", "&") if encoded[-1] == '=': encoded = encoded[:-1] diff --git a/test/mitmproxy/net/http/test_url.py b/test/mitmproxy/net/http/test_url.py index 2064aab8..c9f61faf 100644 --- a/test/mitmproxy/net/http/test_url.py +++ b/test/mitmproxy/net/http/test_url.py @@ -108,6 +108,7 @@ def test_empty_key_trailing_equal_sign(): def test_encode(): assert url.encode([('foo', 'bar')]) assert url.encode([('foo', surrogates)]) + assert not url.encode([], similar_to="justatext") def test_decode(): |