diff options
| author | Alex Stapleton <alexs@prol.etari.at> | 2013-12-28 16:28:59 +0000 |
|---|---|---|
| committer | Alex Stapleton <alexs@prol.etari.at> | 2013-12-28 16:57:26 +0000 |
| commit | 9020b4845a8667a2f400a0fb1b5138cb8d51eaca (patch) | |
| tree | 234cd52a7dc6a13159512a7b5d59338f5f820117 | |
| parent | b50927e8dba16142205684ff9cdeab8b03d57b50 (diff) | |
| download | cryptography-9020b4845a8667a2f400a0fb1b5138cb8d51eaca.tar.gz cryptography-9020b4845a8667a2f400a0fb1b5138cb8d51eaca.tar.bz2 cryptography-9020b4845a8667a2f400a0fb1b5138cb8d51eaca.zip | |
String literals are const char*.
GCC won't whine with -Wall because so much code isn't const correct but
writing to a string literal is undefined. -Wwrite-strings is the warning
flag to enable to spot these.
| -rw-r--r-- | cryptography/hazmat/backends/openssl/opensslv.py | 2 | ||||
| -rw-r--r-- | docs/contributing.rst | 12 |
2 files changed, 7 insertions, 7 deletions
diff --git a/cryptography/hazmat/backends/openssl/opensslv.py b/cryptography/hazmat/backends/openssl/opensslv.py index 4e110327..397f4ca2 100644 --- a/cryptography/hazmat/backends/openssl/opensslv.py +++ b/cryptography/hazmat/backends/openssl/opensslv.py @@ -17,7 +17,7 @@ INCLUDES = """ TYPES = """ static const int OPENSSL_VERSION_NUMBER; -static char *const OPENSSL_VERSION_TEXT; +static const char *const OPENSSL_VERSION_TEXT; """ FUNCTIONS = """ diff --git a/docs/contributing.rst b/docs/contributing.rst index 63c99530..657c4359 100644 --- a/docs/contributing.rst +++ b/docs/contributing.rst @@ -141,17 +141,17 @@ this: .. code-block:: c - #define SOME_INTEGER 0x0; - #define SOME_UINTEGER (unsigned int)0x0001; - #define SOME_STRING "hello"; + #define SOME_INTEGER_LITERAL 0x0; + #define SOME_UNSIGNED_INTEGER_LITERAL 0x0001U; + #define SOME_STRING_LITERAL "hello"; ...it should be added to the bindings like so: .. code-block:: c - static const int SOME_INTEGER; - static const unsigned int SOME_UINTEGER; - static char *const SOME_STRING; + static const int SOME_INTEGER_LITERAL; + static const unsigned int SOME_UNSIGNED_INTEGER_LITERAL; + static const char *const SOME_STRING_LITERAL; Documentation ------------- |