Replace color format conversion macros with proper routines to prevent side effects with using the macro.

Also fix a number of compiler warnings.

2 files changed, 12 insertions, 12 deletions

diff --git a/drivers/multiple/Win32/gdisp_lld_Win32.c b/drivers/multiple/Win32/gdisp_lld_Win32.c
index 50f259b7..adeed579 100644
--- a/drivers/multiple/Win32/gdisp_lld_Win32.c
+++ b/drivers/multiple/Win32/gdisp_lld_Win32.c
@@ -286,9 +286,9 @@ static LRESULT myWindowProc(HWND hWnd,	UINT Msg, WPARAM wParam, LPARAM lParam)
 		// Paint the toggle area
 		#if GINPUT_NEED_TOGGLE
 			if (ps.rcPaint.bottom >= GDISP_SCREEN_HEIGHT && (g->flags & GDISP_FLG_HASTOGGLE)) {
-				pen = CreatePen(PS_SOLID, 1, COLOR2NATIVE(Black));
-				hbrOn = CreateSolidBrush(COLOR2NATIVE(Blue));
-				hbrOff = CreateSolidBrush(COLOR2NATIVE(Gray));
+				pen = CreatePen(PS_SOLID, 1, gdispColor2Native(Black));
+				hbrOn = CreateSolidBrush(gdispColor2Native(Blue));
+				hbrOff = CreateSolidBrush(gdispColor2Native(Gray));
 				old = SelectObject(dc, pen);
 				MoveToEx(dc, 0, GDISP_SCREEN_HEIGHT, &p);
 				LineTo(dc, GDISP_SCREEN_WIDTH, GDISP_SCREEN_HEIGHT);
@@ -514,7 +514,7 @@ LLDSPEC bool_t gdisp_lld_init(GDisplay *g) {
 		COLORREF	color;
 
 		priv = g->priv;
-		color = COLOR2NATIVE(g->p.color);
+		color = gdispColor2Native(g->p.color);
 
 		if (!(g->flags & GDISP_FLG_WSTREAM))
 			BAD_PARAMETER("write_color: not in streaming mode");
@@ -664,7 +664,7 @@ LLDSPEC bool_t gdisp_lld_init(GDisplay *g) {
 			}
 		}
 
-		return NATIVE2COLOR(color);
+		return gdispNative2Color(color);
 	}
 	LLDSPEC	void gdisp_lld_read_stop(GDisplay *g) {
 		if (!(g->flags & GDISP_FLG_WSTREAM))
@@ -680,7 +680,7 @@ LLDSPEC bool_t gdisp_lld_init(GDisplay *g) {
 		COLORREF	color;
 	
 		priv = g->priv;
-		color = COLOR2NATIVE(g->p.color);
+		color = gdispColor2Native(g->p.color);
 	
 		#if GDISP_NEED_CONTROL
 			switch(g->g.Orientation) {
@@ -740,7 +740,7 @@ LLDSPEC bool_t gdisp_lld_init(GDisplay *g) {
 		COLORREF	color;
 
 		priv = g->priv;
-		color = COLOR2NATIVE(g->p.color);
+		color = gdispColor2Native(g->p.color);
 		hbr = CreateSolidBrush(color);
 
 		#if GDISP_NEED_CONTROL
@@ -975,7 +975,7 @@ LLDSPEC bool_t gdisp_lld_init(GDisplay *g) {
 		#endif
 		ReleaseMutex(drawMutex);
 		
-		return NATIVE2COLOR(color);
+		return gdispNative2Color(color);
 	}
 #endif
 
diff --git a/drivers/multiple/uGFXnet/gdisp_lld_uGFXnet.c b/drivers/multiple/uGFXnet/gdisp_lld_uGFXnet.c
index b694358c..81e5d19b 100644
--- a/drivers/multiple/uGFXnet/gdisp_lld_uGFXnet.c
+++ b/drivers/multiple/uGFXnet/gdisp_lld_uGFXnet.c
@@ -425,7 +425,7 @@ LLDSPEC bool_t gdisp_lld_init(GDisplay *g) {
 		buf[0] = GNETCODE_PIXEL;
 		buf[1] = g->p.x;
 		buf[2] = g->p.y;
-		buf[3] = COLOR2NATIVE(g->p.color);
+		buf[3] = gdispColor2Native(g->p.color);
 		MUTEX_ENTER;
 		sendpkt(priv->netfd, buf, 4);
 		MUTEX_EXIT;
@@ -453,7 +453,7 @@ LLDSPEC bool_t gdisp_lld_init(GDisplay *g) {
 		buf[2] = g->p.y;
 		buf[3] = g->p.cx;
 		buf[4] = g->p.cy;
-		buf[5] = COLOR2NATIVE(g->p.color);
+		buf[5] = gdispColor2Native(g->p.color);
 		MUTEX_ENTER;
 		sendpkt(priv->netfd, buf, 6);
 		MUTEX_EXIT;
@@ -490,7 +490,7 @@ LLDSPEC bool_t gdisp_lld_init(GDisplay *g) {
 
 		for(y = 0; y < g->p.cy; y++, buffer += g->p.x2 - g->p.cx) {
 			for(x = 0; x < g->p.cx; x++, buffer++) {
-				buf[0] = COLOR2NATIVE(buffer[0]);
+				buf[0] = gdispColor2Native(buffer[0]);
 				sendpkt(priv->netfd, buf, 1);
 			}
 		}
@@ -524,7 +524,7 @@ LLDSPEC bool_t gdisp_lld_init(GDisplay *g) {
 		while(!(g->flags & GDISP_FLG_HAVEDATA) || priv->data[0] != GNETCODE_READ)
 			gfxSleepMilliseconds(1);
 		
-		data = NATIVE2COLOR(priv->data[1]);
+		data = gdispNative2Color(priv->data[1]);
 		g->flags &= ~GDISP_FLG_HAVEDATA;
 
 		return data;