diff options
| author | Gennadiy Civil <gennadiycivil@users.noreply.github.com> | 2018-01-05 10:18:26 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-01-05 10:18:26 -0500 |
| commit | 5b26b0fce73eda28890d1c9baff4eb4e5aa7d9d2 (patch) | |
| tree | e76ee1c2169a9551829d8fce649d393474d8dd2e /googlemock | |
| parent | abbc0f8174d92b8a52dd893cf31be6f7af5d0de7 (diff) | |
| parent | 6b4967a23aae2f6d63a356d1db8746cb5250be26 (diff) | |
| download | googletest-5b26b0fce73eda28890d1c9baff4eb4e5aa7d9d2.tar.gz googletest-5b26b0fce73eda28890d1c9baff4eb4e5aa7d9d2.tar.bz2 googletest-5b26b0fce73eda28890d1c9baff4eb4e5aa7d9d2.zip | |
Merge pull request #1007 from davidben/missing-declarations
Pass the -Wmissing-declarations warning.
Diffstat (limited to 'googlemock')
| -rw-r--r-- | googlemock/include/gmock/gmock-matchers.h | 4 | ||||
| -rw-r--r-- | googlemock/src/gmock-spec-builders.cc | 2 | ||||
| -rw-r--r-- | googlemock/test/gmock-matchers_test.cc | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/googlemock/include/gmock/gmock-matchers.h b/googlemock/include/gmock/gmock-matchers.h index c446bf7d..3367a0b5 100644 --- a/googlemock/include/gmock/gmock-matchers.h +++ b/googlemock/include/gmock/gmock-matchers.h @@ -3615,6 +3615,10 @@ BoundSecondMatcher<Tuple2Matcher, Second> MatcherBindSecond( return BoundSecondMatcher<Tuple2Matcher, Second>(tm, second); } +// Joins a vector of strings as if they are fields of a tuple; returns +// the joined string. This function is exported for testing. +GTEST_API_ string JoinAsTuple(const Strings& fields); + // Returns the description for a matcher defined using the MATCHER*() // macro where the user-supplied description string is "", if // 'negation' is false; otherwise returns the description of the diff --git a/googlemock/src/gmock-spec-builders.cc b/googlemock/src/gmock-spec-builders.cc index fc4968ba..93a83ae5 100644 --- a/googlemock/src/gmock-spec-builders.cc +++ b/googlemock/src/gmock-spec-builders.cc @@ -508,7 +508,7 @@ bool UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked() return expectations_met; } -CallReaction intToCallReaction(int mock_behavior) { +static CallReaction intToCallReaction(int mock_behavior) { if (mock_behavior >= kAllow && mock_behavior <= kFail) { return static_cast<internal::CallReaction>(mock_behavior); } diff --git a/googlemock/test/gmock-matchers_test.cc b/googlemock/test/gmock-matchers_test.cc index 4beaec4c..5c764eb4 100644 --- a/googlemock/test/gmock-matchers_test.cc +++ b/googlemock/test/gmock-matchers_test.cc @@ -65,10 +65,6 @@ namespace testing { -namespace internal { -GTEST_API_ string JoinAsTuple(const Strings& fields); -} // namespace internal - namespace gmock_matchers_test { using std::greater; |
