diff options
| author | Peter Levine <plevine457@gmail.com> | 2018-09-14 19:40:51 -0400 | 
|---|---|---|
| committer | Peter Levine <plevine457@gmail.com> | 2018-09-14 19:40:51 -0400 | 
| commit | 149c0d24148da9a339d6c9d03e638a39c59731f6 (patch) | |
| tree | d4d1991631be4474135690b7fa3ec15f014ffd8a | |
| parent | bc2d0935b74917be0821bfd834472ed9cc4a3b5b (diff) | |
| download | googletest-149c0d24148da9a339d6c9d03e638a39c59731f6.tar.gz googletest-149c0d24148da9a339d6c9d03e638a39c59731f6.tar.bz2 googletest-149c0d24148da9a339d6c9d03e638a39c59731f6.zip  | |
Fix Python3 support
| -rwxr-xr-x | googletest/test/googletest-env-var-test.py | 4 | ||||
| -rwxr-xr-x | googletest/test/googletest-filter-unittest.py | 13 | ||||
| -rwxr-xr-x | googletest/test/googletest-output-test.py | 2 | ||||
| -rwxr-xr-x | googletest/test/googletest-throw-on-failure-test.py | 2 | ||||
| -rwxr-xr-x | googletest/test/googletest-uninitialized-test.py | 4 | ||||
| -rwxr-xr-x | googletest/test/gtest_xml_output_unittest.py | 3 | ||||
| -rwxr-xr-x | googletest/test/gtest_xml_test_utils.py | 2 | 
7 files changed, 17 insertions, 13 deletions
diff --git a/googletest/test/googletest-env-var-test.py b/googletest/test/googletest-env-var-test.py index e1efeee1..2f0e406a 100755 --- a/googletest/test/googletest-env-var-test.py +++ b/googletest/test/googletest-env-var-test.py @@ -45,8 +45,8 @@ environ = os.environ.copy()  def AssertEq(expected, actual):    if expected != actual: -    print 'Expected: %s' % (expected,) -    print '  Actual: %s' % (actual,) +    print('Expected: %s' % (expected,)) +    print('  Actual: %s' % (actual,))      raise AssertionError diff --git a/googletest/test/googletest-filter-unittest.py b/googletest/test/googletest-filter-unittest.py index dc0b5bd9..6b32f2d2 100755 --- a/googletest/test/googletest-filter-unittest.py +++ b/googletest/test/googletest-filter-unittest.py @@ -42,7 +42,10 @@ we test that here also.  import os  import re -import sets +try: +  from sets import Set as set  # For Python 2.3 compatibility +except ImportError: +  pass  import sys  import gtest_test_utils @@ -57,7 +60,7 @@ CAN_PASS_EMPTY_ENV = False  if sys.executable:    os.environ['EMPTY_VAR'] = ''    child = gtest_test_utils.Subprocess( -      [sys.executable, '-c', 'import os; print \'EMPTY_VAR\' in os.environ']) +      [sys.executable, '-c', 'import os; print(\'EMPTY_VAR\' in os.environ)'])    CAN_PASS_EMPTY_ENV = eval(child.output) @@ -72,7 +75,7 @@ if sys.executable:    os.environ['UNSET_VAR'] = 'X'    del os.environ['UNSET_VAR']    child = gtest_test_utils.Subprocess( -      [sys.executable, '-c', 'import os; print \'UNSET_VAR\' not in os.environ' +      [sys.executable, '-c', 'import os; print(\'UNSET_VAR\' not in os.environ)'        ])    CAN_UNSET_ENV = eval(child.output) @@ -245,14 +248,14 @@ class GTestFilterUnitTest(gtest_test_utils.TestCase):      for slice_var in list_of_sets:        full_partition.extend(slice_var)      self.assertEqual(len(set_var), len(full_partition)) -    self.assertEqual(sets.Set(set_var), sets.Set(full_partition)) +    self.assertEqual(set(set_var), set(full_partition))    def AdjustForParameterizedTests(self, tests_to_run):      """Adjust tests_to_run in case value parameterized tests are disabled."""      global param_tests_present      if not param_tests_present: -      return list(sets.Set(tests_to_run) - sets.Set(PARAM_TESTS)) +      return list(set(tests_to_run) - set(PARAM_TESTS))      else:        return tests_to_run diff --git a/googletest/test/googletest-output-test.py b/googletest/test/googletest-output-test.py index 2d69e353..1a9ee6e3 100755 --- a/googletest/test/googletest-output-test.py +++ b/googletest/test/googletest-output-test.py @@ -287,7 +287,7 @@ class GTestOutputTest(gtest_test_utils.TestCase):      # sequences when we read the golden file irrespective of an operating      # system used. Therefore, we need to strip those \r's from newlines      # unconditionally. -    golden = ToUnixLineEnding(golden_file.read()) +    golden = ToUnixLineEnding(golden_file.read().decode())      golden_file.close()      # We want the test to pass regardless of certain features being diff --git a/googletest/test/googletest-throw-on-failure-test.py b/googletest/test/googletest-throw-on-failure-test.py index 46cb9f6d..204e43e7 100755 --- a/googletest/test/googletest-throw-on-failure-test.py +++ b/googletest/test/googletest-throw-on-failure-test.py @@ -68,7 +68,7 @@ def SetEnvVar(env_var, value):  def Run(command):    """Runs a command; returns True/False if its exit code is/isn't 0.""" -  print 'Running "%s". . .' % ' '.join(command) +  print('Running "%s". . .' % ' '.join(command))    p = gtest_test_utils.Subprocess(command)    return p.exited and p.exit_code == 0 diff --git a/googletest/test/googletest-uninitialized-test.py b/googletest/test/googletest-uninitialized-test.py index 5b7d1e74..69595a0d 100755 --- a/googletest/test/googletest-uninitialized-test.py +++ b/googletest/test/googletest-uninitialized-test.py @@ -43,8 +43,8 @@ def Assert(condition):  def AssertEq(expected, actual):    if expected != actual: -    print 'Expected: %s' % (expected,) -    print '  Actual: %s' % (actual,) +    print('Expected: %s' % (expected,)) +    print('  Actual: %s' % (actual,))      raise AssertionError diff --git a/googletest/test/gtest_xml_output_unittest.py b/googletest/test/gtest_xml_output_unittest.py index faedd4e6..8669f19e 100755 --- a/googletest/test/gtest_xml_output_unittest.py +++ b/googletest/test/gtest_xml_output_unittest.py @@ -266,7 +266,8 @@ class GTestXMLOutputUnitTest(gtest_xml_test_utils.GTestXMLTestCase):          'gtest_no_test_unittest')      try:        os.remove(output_file) -    except OSError, e: +    except OSError: +      e = sys.exc_info()[1]        if e.errno != errno.ENOENT:          raise diff --git a/googletest/test/gtest_xml_test_utils.py b/googletest/test/gtest_xml_test_utils.py index 1e035859..afcf55e0 100755 --- a/googletest/test/gtest_xml_test_utils.py +++ b/googletest/test/gtest_xml_test_utils.py @@ -94,7 +94,7 @@ class GTestXMLTestCase(gtest_test_utils.TestCase):      self.assertEquals(          len(expected_children), len(actual_children),          'number of child elements differ in element ' + actual_node.tagName) -    for child_id, child in expected_children.iteritems(): +    for child_id, child in expected_children.items():        self.assert_(child_id in actual_children,                     '<%s> is not in <%s> (in element %s)' %                     (child_id, actual_children, actual_node.tagName))  | 
