diff options
| author | Konstantin Đorđević <vomindoraan@gmail.com> | 2019-01-27 09:28:40 +0100 |
|---|---|---|
| committer | Drashna Jaelre <drashna@live.com> | 2019-01-27 00:28:40 -0800 |
| commit | 4d9b11af14fd83c1e6b556165d41ce005abb4a84 (patch) | |
| tree | 99b363853ad21f1d4e6a2ddf0af6f2407c363e96 /tmk_core | |
| parent | 53d86b2c579b5a5f3488b80f843c274977263ce8 (diff) | |
| download | firmware-4d9b11af14fd83c1e6b556165d41ce005abb4a84.tar.gz firmware-4d9b11af14fd83c1e6b556165d41ce005abb4a84.tar.bz2 firmware-4d9b11af14fd83c1e6b556165d41ce005abb4a84.zip | |
Fix Command feature: use get_mods() instead of keyboard_report->mods (#4955)
* Remove unnecessary IS_COMMAND definition in clueboard/66/rev4
* Replace keyboard_report->mods with get_mods() in IS_COMMAND definitions
* Update docs to use get_mods() instead of keyboard_report->mods
* Replace keyboard_report->mods with get_mods() in tmk_core/protocol/usb_hid/test
For some reason, this occurrence used KB_LSHIFT and KB_RSHIFT, which don't exist
* Replace keyboard_report->mods with get_mods() in Massdrop keyboards (as per @patrickmt)
Diffstat (limited to 'tmk_core')
| -rw-r--r-- | tmk_core/common/command.h | 2 | ||||
| -rw-r--r-- | tmk_core/protocol/usb_hid/test/config.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/tmk_core/common/command.h b/tmk_core/common/command.h index e25b97463..052e25184 100644 --- a/tmk_core/common/command.h +++ b/tmk_core/common/command.h @@ -35,7 +35,7 @@ bool command_proc(uint8_t code); #endif #ifndef IS_COMMAND -#define IS_COMMAND() (keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT))) +#define IS_COMMAND() (get_mods() == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT))) #endif #ifndef MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS diff --git a/tmk_core/protocol/usb_hid/test/config.h b/tmk_core/protocol/usb_hid/test/config.h index c2230fb57..a2403fe9c 100644 --- a/tmk_core/protocol/usb_hid/test/config.h +++ b/tmk_core/protocol/usb_hid/test/config.h @@ -35,6 +35,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. /* key combination for command */ -#define IS_COMMAND() (keyboard_report->mods == (MOD_BIT(KB_LSHIFT) | MOD_BIT(KB_RSHIFT))) +#define IS_COMMAND() (get_mods() == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT))) #endif |