aboutsummaryrefslogtreecommitdiffstats
path: root/tools/debugger/kdd/kdd-xen.c
blob: 4fbea7df735169a023bf9368c9e63399d8513f3a (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
/*
 * kdd-xen.c -- xen-specific functions for the kdd debugging stub
 *
 * Tim Deegan <Tim.Deegan@citrix.com>
 * 
 * Copyright (c) 2007-2010, Citrix Systems Inc.
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
 *
 * Redistributions in binary form must reproduce the above copyright
 * notice, this list of conditions and the following disclaimer in the
 * documentation and/or other materials provided with the distribution.
 *
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
 * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
 * COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
 * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
 * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
 * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 * POSSIBILITY OF SUCH DAMAGE.
 */

#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include <stdio.h>
#include <errno.h>
#include <inttypes.h>
#include <sys/types.h>
#include <sys/mman.h>

#include <xenctrl.h>
#include <xen/xen.h>
#include <xen/hvm/save.h>

#include "kdd.h"

#define MAPSIZE 4093 /* Prime */

#define PAGE_SHIFT 12
#define PAGE_SIZE (1U << PAGE_SHIFT)

struct kdd_guest {
    struct xentoollog_logger xc_log; /* Must be first for xc log callbacks */
    xc_interface *xc_handle;
    uint32_t domid;
    char id[80];
    FILE *log;
    int verbosity;
    void *hvm_buf;
    uint32_t hvm_sz;
    uint32_t pfns[MAPSIZE];
    void * maps[MAPSIZE];
};


/* Flush any mappings we have of the guest memory: it's not polite
 * top hold on to them while the guest is running */
static void flush_maps(kdd_guest *g)
{
    int i;
    for (i = 0; i < MAPSIZE; i++) {
        if (g->maps[i] != NULL)
            munmap(g->maps[i], PAGE_SIZE);
        g->maps[i] = NULL;
    }
}


/* Halt the guest so we can debug it */
void kdd_halt(kdd_guest *g)
{
    uint32_t sz;
    void *buf;

    xc_domain_pause(g->xc_handle, g->domid);

    /* How much space do we need for the HVM state? */
    sz = xc_domain_hvm_getcontext(g->xc_handle, g->domid, 0, 0);
    if (sz == (uint32_t) -1) {
        KDD_LOG(g, "Can't get HVM state size for domid %"PRIu32": %s\n",
                g->domid, strerror(errno));
        return;
    }
    buf = realloc(g->hvm_buf, sz);
    if (!buf) {
        KDD_LOG(g, "Couldn't allocate %"PRIu32" for HVM buffer\n", sz);
        return;
    }
    g->hvm_buf = buf;
    g->hvm_sz = sz;
    memset(buf, 0, sz);

    /* Get the HVM state */
    sz = xc_domain_hvm_getcontext(g->xc_handle, g->domid, buf, sz);
    if (sz == (uint32_t) -1) {
        KDD_LOG(g, "Can't get HVM state for domid %"PRIu32": %s\n",
                g->domid, strerror(errno));
    }
}

/* Check whether the guest has stopped.  Returns 'interesting' vcpu or -1 */
/* TODO: open DEBUG_VIRQ if it's free and wait for events rather than
 * always polling the guest state */
int kdd_poll_guest(kdd_guest *g)
{
    /* TODO: finish plumbing through polling for breakpoints */
    return 0;
}

/* Update the HVM state */
static void hvm_writeback(kdd_guest *g)
{
    if (g->hvm_buf && xc_domain_hvm_setcontext(g->xc_handle, g->domid, 
                                               g->hvm_buf, g->hvm_sz))
        KDD_LOG(g, "Can't set HVM state for domid %"PRIu32": %s\n",
                g->domid, strerror(errno));
}

/* Start the guest running again */
void kdd_run(kdd_guest *g)
{
    flush_maps(g);
    hvm_writeback(g);
    xc_domain_unpause(g->xc_handle, g->domid);
}

/* How many CPUs are there in this guest? */
int kdd_count_cpus(kdd_guest *g)
{
    struct hvm_save_descriptor *desc;
    int maxcpu = 0;

    if (!g->hvm_buf)
        return 0;

    /* Scan the CPU save records. */
    for (desc = g->hvm_buf;
         (void *) desc >= g->hvm_buf && (void *) desc < g->hvm_buf + g->hvm_sz;
         desc = ((void *)desc) + (sizeof *desc) + desc->length) {
        if (desc->typecode == HVM_SAVE_CODE(CPU)) {
            if (maxcpu < desc->instance) 
                maxcpu = desc->instance;
        }
    }
    return maxcpu + 1;
}

/* Helper fn: get CPU state from cached HVM state */
static struct hvm_hw_cpu *get_cpu(kdd_guest *g, int cpuid)
{
    struct hvm_save_descriptor *desc;
    struct hvm_hw_cpu *cpu;

    if (!g->hvm_buf)
        return NULL;

    /* Find the right CPU */
    for (desc = g->hvm_buf;
         (void *) desc >= g->hvm_buf && (void *) desc < g->hvm_buf + g->hvm_sz;
         desc = ((void *)desc) + (sizeof *desc) + desc->length) {
        if (desc->typecode == HVM_SAVE_CODE(CPU) && desc->instance == cpuid) {
            cpu = ((void *)desc) + (sizeof *desc);
            if ((void *) cpu + sizeof (*cpu) <= g->hvm_buf + g->hvm_sz)
                return cpu;
        }
    }
    
    KDD_LOG(g, "Dom %"PRIu32" has no CPU %i\n", g->domid, cpuid);
    return NULL;
}

/* Helper fn: get APIC state from cached HVM state */
static struct hvm_hw_lapic_regs *get_lapic(kdd_guest *g, int cpuid)
{
    struct hvm_save_descriptor *desc;
    struct hvm_hw_lapic_regs *regs;

    if (!g->hvm_buf)
        return NULL;

    /* Find the right CPU's LAPIC */
    for (desc = g->hvm_buf;
         (void *) desc >= g->hvm_buf && (void *) desc < g->hvm_buf + g->hvm_sz;
         desc = ((void *)desc) + (sizeof *desc) + desc->length) {
        if (desc->typecode == HVM_SAVE_CODE(LAPIC_REGS) && desc->instance == cpuid) {
            regs = ((void *)desc) + (sizeof *desc);
            if ((void *) regs + sizeof (*regs) <= g->hvm_buf + g->hvm_sz)
                return regs;
        }
    }
    
    KDD_LOG(g, "Dom %"PRIu32" has no LAPIC %i\n", g->domid, cpuid);
    return NULL;
}


/* Accessors for guest user registers */
static void kdd_get_regs_x86_32(struct hvm_hw_cpu *cpu, kdd_regs_x86_32 *r)
{
    r->gs     = cpu->gs_sel;
    r->fs     = cpu->fs_sel;
    r->es     = cpu->es_sel;
    r->ds     = cpu->ds_sel;
    r->edi    = cpu->rdi;
    r->esi    = cpu->rsi;
    r->ebx    = cpu->rbx;
    r->edx    = cpu->rdx;
    r->ecx    = cpu->rcx;
    r->eax    = cpu->rax;
    r->ebp    = cpu->rbp;
    r->eip    = cpu->rip;
    r->cs     = cpu->cs_sel;
    r->eflags = cpu->rflags;
    r->esp    = cpu->rsp;
    r->ss     = cpu->ss_sel;
    memcpy(r->fp, cpu->fpu_regs, 112); // 108 save area + 4 of ???
}

static void kdd_set_regs_x86_32(struct hvm_hw_cpu *cpu, kdd_regs_x86_32 *r)
{
    cpu->gs_sel = r->gs;
    cpu->fs_sel = r->fs;
    cpu->es_sel = r->es;
    cpu->ds_sel = r->ds;
    cpu->rdi    = r->edi;
    cpu->rsi    = r->esi;
    cpu->rbx    = r->ebx;
    cpu->rdx    = r->edx;
    cpu->rcx    = r->ecx;
    cpu->rax    = r->eax;
    cpu->rbp    = r->ebp;
    cpu->rip    = r->eip;
    cpu->cs_sel = r->cs;
    cpu->rflags = r->eflags;
    cpu->rsp    = r->esp;
    cpu->ss_sel = r->ss;
    memcpy(cpu->fpu_regs, r->fp, 112); // 108 save area + 4 of ???
}

static void kdd_get_regs_x86_64(struct hvm_hw_cpu *cpu, kdd_regs_x86_64 *r)
{
    // XXX debug pattern
    uint16_t i;
    for (i = 0 ; i < (sizeof *r / 2) ; i++)
        ((uint16_t *)r)[i] = i;

    r->cs     = cpu->cs_sel;
    r->ds     = cpu->ds_sel;
    r->es     = cpu->es_sel;
    r->fs     = cpu->fs_sel;
    r->gs     = cpu->gs_sel;
    r->ss     = cpu->ss_sel;
    r->rflags = cpu->rflags;
    r->dr0    = cpu->dr0;
    r->dr1    = cpu->dr1;
    r->dr2    = cpu->dr2;
    r->dr3    = cpu->dr3;
    r->dr6    = cpu->dr6;
    r->dr7    = cpu->dr7;
    r->rax    = cpu->rax;
    r->rcx    = cpu->rcx;
    r->rdx    = cpu->rdx;
    r->rbx    = cpu->rbx;
    r->rsp    = cpu->rsp;
    r->rbp    = cpu->rbp;
    r->rsi    = cpu->rsi;
    r->rdi    = cpu->rdi;
    r->r8     = cpu->r8;
    r->r9     = cpu->r9;
    r->r10    = cpu->r10;
    r->r11    = cpu->r11;
    r->r12    = cpu->r12;
    r->r13    = cpu->r13;
    r->r14    = cpu->r14;
    r->r15    = cpu->r15;
    r->rip    = cpu->rip;
    memcpy(r->fp, cpu->fpu_regs, 112); // Definitely not right
}

static void kdd_set_regs_x86_64(struct hvm_hw_cpu *cpu, kdd_regs_x86_64 *r)
{
    cpu->cs_sel = r->cs;
    cpu->ds_sel = r->ds;
    cpu->es_sel = r->es;
    cpu->fs_sel = r->fs;
    cpu->gs_sel = r->gs;
    cpu->ss_sel = r->ss;
    cpu->rflags = r->rflags;
    cpu->dr0    = r->dr0;
    cpu->dr1    = r->dr1;
    cpu->dr2    = r->dr2;
    cpu->dr3    = r->dr3;
    cpu->dr6    = r->dr6;
    cpu->dr7    = r->dr7;
    cpu->rax    = r->rax;
    cpu->rcx    = r->rcx;
    cpu->rdx    = r->rdx;
    cpu->rbx    = r->rbx;
    cpu->rsp    = r->rsp;
    cpu->rbp    = r->rbp;
    cpu->rsi    = r->rsi;
    cpu->rdi    = r->rdi;
    cpu->r8     = r->r8;
    cpu->r9     = r->r9;
    cpu->r10    = r->r10;
    cpu->r11    = r->r11;
    cpu->r12    = r->r12;
    cpu->r13    = r->r13;
    cpu->r14    = r->r14;
    cpu->r15    = r->r15;
    cpu->rip    = r->rip;
    memcpy(r->fp, cpu->fpu_regs, 112); // Definitely not right
}


int kdd_get_regs(kdd_guest *g, int cpuid, kdd_regs *r, int w64)
{
    struct hvm_hw_cpu *cpu; 
    
    cpu = get_cpu(g, cpuid);
    if (!cpu) 
        return -1;

    memset(r, 0, sizeof(*r));
    
    if (w64)
        kdd_get_regs_x86_64(cpu, &r->r64);
    else
        kdd_get_regs_x86_32(cpu, &r->r32);

    return 0;
}

int kdd_set_regs(kdd_guest *g, int cpuid, kdd_regs *r, int w64)
{
    struct hvm_hw_cpu *cpu; 
    
    cpu = get_cpu(g, cpuid);
    if (!cpu) 
        return -1;
    
    if (w64)
        kdd_set_regs_x86_64(cpu, &r->r64);
    else
        kdd_set_regs_x86_32(cpu, &r->r32);

    hvm_writeback(g);
    return 0;
}


/* Accessors for guest control registers */
static void kdd_get_ctrl_x86_32(struct hvm_hw_cpu *cpu, kdd_ctrl_x86_32 *c)
{    
    c->cr0 = cpu->cr0;
    c->cr2 = cpu->cr2;
    c->cr3 = cpu->cr3;
    c->cr4 = cpu->cr4;
    c->dr0 = cpu->dr0;
    c->dr1 = cpu->dr1;
    c->dr2 = cpu->dr2;
    c->dr3 = cpu->dr3;
    c->dr6 = cpu->dr6;
    c->dr7 = cpu->dr7;
    c->gdt_base = cpu->gdtr_base;
    c->gdt_limit = cpu->gdtr_limit;
    c->idt_base = cpu->idtr_base;
    c->idt_limit = cpu->idtr_limit;
    c->tss_sel = cpu->tr_sel;
    c->ldt_sel = cpu->ldtr_sel;
}

static void kdd_get_ctrl_x86_64(struct hvm_hw_cpu *cpu, 
                                struct hvm_hw_lapic_regs *lapic,
                                kdd_ctrl_x86_64 *c)
{    
    c->cr0 = cpu->cr0;
    c->cr2 = cpu->cr2;
    c->cr3 = cpu->cr3;
    c->cr4 = cpu->cr4;
    c->dr0 = cpu->dr0;
    c->dr1 = cpu->dr1;
    c->dr2 = cpu->dr2;
    c->dr3 = cpu->dr3;
    c->dr6 = cpu->dr6;
    c->dr7 = cpu->dr7;
    c->gdt_base = cpu->gdtr_base;
    c->gdt_limit = cpu->gdtr_limit;
    c->idt_base = cpu->idtr_base;
    c->idt_limit = cpu->idtr_limit;
    c->tss_sel = cpu->tr_sel;
    c->ldt_sel = cpu->ldtr_sel;
    c->cr8 = lapic->data[0x80] >> 4; /* Top half of the low byte of the TPR */
}


int kdd_get_ctrl(kdd_guest *g, int cpuid, kdd_ctrl *ctrl, int w64)
{
    struct hvm_hw_cpu *cpu; 
    struct hvm_hw_lapic_regs *lapic;

    cpu = get_cpu(g, cpuid);
    if (!cpu)
        return -1;

    if (w64) {
        lapic = get_lapic(g, cpuid);
        if (!lapic)
            return -1;
        kdd_get_ctrl_x86_64(cpu, lapic, &ctrl->c64);
    } else {
        kdd_get_ctrl_x86_32(cpu, &ctrl->c32);
    }

    return 0;
}

int kdd_wrmsr(kdd_guest *g, int cpuid, uint32_t msr, uint64_t value)
{
    struct hvm_hw_cpu *cpu;

    cpu = get_cpu(g, cpuid);
    if (!cpu)
        return -1;
    
    switch (msr) {
    case 0x00000174: cpu->sysenter_cs = value; break;
    case 0x00000175: cpu->sysenter_esp = value; break;
    case 0x00000176: cpu->sysenter_eip = value; break;
    case 0xc0000080: cpu->msr_efer = value; break;
    case 0xc0000081: cpu->msr_star = value; break;
    case 0xc0000082: cpu->msr_lstar = value; break;
    case 0xc0000083: cpu->msr_cstar = value; break;
    case 0xc0000084: cpu->msr_syscall_mask = value; break;
    case 0xc0000100: cpu->fs_base = value; break;
    case 0xc0000101: cpu->gs_base = value; break;
    case 0xc0000102: cpu->shadow_gs = value; break;
    default:
        return -1;
    }

    hvm_writeback(g);
    return 0;   
}

int kdd_rdmsr(kdd_guest *g, int cpuid, uint32_t msr, uint64_t *value)
{
    struct hvm_hw_cpu *cpu;

    cpu = get_cpu(g, cpuid);
    if (!cpu)
        return -1;
    
    switch (msr) {
    case 0x00000174: *value = cpu->sysenter_cs; break;
    case 0x00000175: *value = cpu->sysenter_esp; break;
    case 0x00000176: *value = cpu->sysenter_eip; break;
    case 0xc0000080: *value = cpu->msr_efer; break;
    case 0xc0000081: *value = cpu->msr_star; break;
    case 0xc0000082: *value = cpu->msr_lstar; break;
    case 0xc0000083: *value = cpu->msr_cstar; break;
    case 0xc0000084: *value = cpu->msr_syscall_mask; break;
    case 0xc0000100: *value = cpu->fs_base; break;
    case 0xc0000101: *value = cpu->gs_base; break;
    case 0xc0000102: *value = cpu->shadow_gs; break;
    default:
        return -1;
    }

    return 0;   
}


/* Accessor for guest physical memory */
static uint32_t kdd_access_physical_page(kdd_guest *g, uint64_t addr, 
                                         uint32_t len, uint8_t *buf, int write)
{
    uint32_t map_pfn, map_offset;
    uint8_t *map;

    map_pfn = (addr >> PAGE_SHIFT);
    map_offset = addr & (PAGE_SIZE - 1);

    /* Evict any mapping of the wrong frame from our slot */ 
    if (g->pfns[map_pfn % MAPSIZE] != map_pfn
        && g->maps[map_pfn % MAPSIZE] != NULL) {
        munmap(g->maps[map_pfn % MAPSIZE], PAGE_SIZE);
        g->maps[map_pfn % MAPSIZE] = NULL;
    }
    g->pfns[map_pfn % MAPSIZE] = map_pfn;

    /* Now map the frame if it's not already there */
    if (g->maps[map_pfn % MAPSIZE] != NULL)
        map = g->maps[map_pfn % MAPSIZE];
    else {
        map = xc_map_foreign_range(g->xc_handle,
                                   g->domid,
                                   PAGE_SIZE,
                                   PROT_READ|PROT_WRITE,
                                   map_pfn);

        KDD_DEBUG(g, "map: %u, 0x%16.16"PRIx32": %p +0x%"PRIx32"\n",
                  write ? PROT_READ|PROT_WRITE : PROT_READ,
                  map_pfn, map, map_offset);

        if (!map) 
            return 0;
        g->maps[map_pfn % MAPSIZE] = map;
    }

    if (write) 
        memcpy(map + map_offset, buf, len);
    else
        memcpy(buf, map + map_offset, len);

    return len;
}

uint32_t kdd_access_physical(kdd_guest *g, uint64_t addr, 
                             uint32_t len, uint8_t *buf, int write)
{
    uint32_t chunk, rv, done = 0;
    while (len > 0) {
        chunk = PAGE_SIZE - (addr & (PAGE_SIZE - 1));
        if (chunk > len) 
            chunk = len;
        rv = kdd_access_physical_page(g, addr, chunk, buf, write);
        done += rv;
        if (rv != chunk)
            return done;
        addr += chunk;
        buf += chunk;
        len -= chunk;
    }
    return done;
}


/* Plumb libxc log messages into our own logging */
static void kdd_xc_log(struct xentoollog_logger *logger,
                       xentoollog_level level,
                       int errnoval /* or -1 */,
                       const char *context /* eg "xc", "xl", may be 0 */,
                       const char *format /* without level, context, \n */,
                       va_list al)
{
    kdd_guest *g = (kdd_guest *) logger;
    /* Suppress most libxc levels unless we're logging at debug level */
    if (g->verbosity < 1 || (level < XTL_WARN && g->verbosity < 3))
        return;
    fprintf(g->log, "libxc[%s:%i:%i]: ", context ? : "?", level, errnoval);
    vfprintf(g->log, format, al);
    fprintf(g->log, "\n");
    (void) fflush(g->log);
}


/* Set up guest-specific state */
kdd_guest *kdd_guest_init(char *arg, FILE *log, int verbosity)
{
    kdd_guest *g = NULL;
    xc_interface *xch = NULL;
    uint32_t domid;
    xc_dominfo_t info;

    g = calloc(1, sizeof (kdd_guest));
    if (!g) 
        goto err;
    g->log = log;
    g->verbosity = verbosity;
    g->xc_log.vmessage = kdd_xc_log;

    xch = xc_interface_open(&g->xc_log, NULL, 0);
    if (!xch)
        goto err;
    g->xc_handle = xch;

    domid = strtoul(arg, NULL, 0);
    if (domid == 0)
        goto err;
    g->domid = domid;

    /* Check that the domain exists and is HVM */
    if (xc_domain_getinfo(xch, domid, 1, &info) != 1 || !info.hvm)
        goto err;

    snprintf(g->id, (sizeof g->id) - 1, 
             "a xen guest with domain id %i", g->domid);

    return g;

 err:
    free(g);
    if (xch)
        xc_interface_close(xch);
    return NULL;
}

/* Say what kind of guest this is */
char *kdd_guest_identify(kdd_guest *g)
{
    return g->id;
}

/* Tear down guest-specific state */
void kdd_guest_teardown(kdd_guest *g)
{
    flush_maps(g);
    xc_interface_close(g->xc_handle);
    free(g->id);
    free(g->hvm_buf);
    free(g);
}