aboutsummaryrefslogtreecommitdiffstats
path: root/xen
diff options
context:
space:
mode:
authorAndrew Cooper <andrew.cooper3@citrix.com>2013-09-25 10:45:53 +0200
committerJan Beulich <jbeulich@suse.com>2013-09-25 10:45:53 +0200
commitae7c6b64c063a755097806e30dc24b94fabbda09 (patch)
tree8b6f6e0ae52102386491e91a76a2dbf34f451245 /xen
parent688eeb878cc58150bf6e729c9c1836b8c1e4cc8f (diff)
downloadxen-ae7c6b64c063a755097806e30dc24b94fabbda09.tar.gz
xen-ae7c6b64c063a755097806e30dc24b94fabbda09.tar.bz2
xen-ae7c6b64c063a755097806e30dc24b94fabbda09.zip
x86/hap: Remove bogus assertion in hap_free_p2m_page()
Coverity ID: 1055622 Coverity correctly points out that this ASSERT() is unconditionally true as an unsigned integer is always >= 0. Judging from the shadow counterpart and p2m callsites, there is nothing invalid about freeing the final p2m page. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Acked-by: Tim Deegan <tim@xen.org>
Diffstat (limited to 'xen')
-rw-r--r--xen/arch/x86/mm/hap/hap.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c
index bff05d97a3..d3f64bdb97 100644
--- a/xen/arch/x86/mm/hap/hap.c
+++ b/xen/arch/x86/mm/hap/hap.c
@@ -289,7 +289,6 @@ static void hap_free_p2m_page(struct domain *d, struct page_info *pg)
d->arch.paging.hap.p2m_pages--;
d->arch.paging.hap.total_pages++;
hap_free(d, page_to_mfn(pg));
- ASSERT(d->arch.paging.hap.p2m_pages >= 0);
paging_unlock(d);
}