aboutsummaryrefslogtreecommitdiffstats
path: root/xen
diff options
context:
space:
mode:
authorGeorge Dunlap <george.dunlap@eu.citrix.com>2013-09-18 14:45:24 +0200
committerJan Beulich <jbeulich@suse.com>2013-09-18 14:45:24 +0200
commit925fbcb7fdd6238f26b1576dc1f3e297f1f24f1e (patch)
tree9bd3d86bd973224f2241431b047ccf654b46ba91 /xen
parentcf59b4cd9f85631d4c38d6df05e7e432fca5a8f0 (diff)
downloadxen-925fbcb7fdd6238f26b1576dc1f3e297f1f24f1e.tar.gz
xen-925fbcb7fdd6238f26b1576dc1f3e297f1f24f1e.tar.bz2
xen-925fbcb7fdd6238f26b1576dc1f3e297f1f24f1e.zip
x86/HVM: fix failure path in hvm_vcpu_initialise
It looks like one of the failure cases in hvm_vcpu_initialise jumps to the wrong label; this could lead to slow leaks if something isn't cleaned up properly. I will probably change these labels in a future patch, but I figured it was better to have this fix separately. This is also a candidate for backport. Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com> Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
Diffstat (limited to 'xen')
-rw-r--r--xen/arch/x86/hvm/hvm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 8fd218e2f7..72031846db 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1118,7 +1118,7 @@ int hvm_vcpu_initialise(struct vcpu *v)
/* Create bufioreq event channel. */
rc = alloc_unbound_xen_event_channel(v, dm_domid, NULL);
if ( rc < 0 )
- goto fail2;
+ goto fail4;
d->arch.hvm_domain.params[HVM_PARAM_BUFIOREQ_EVTCHN] = rc;
}