diff options
author | Ian Campbell <ian.campbell@citrix.com> | 2013-07-19 12:51:11 +0100 |
---|---|---|
committer | Ian Campbell <ian.campbell@citrix.com> | 2013-08-20 15:41:30 +0100 |
commit | 33daac3995d49d07fec245ea22f2c093fb11bec2 (patch) | |
tree | 4eea955d9d0607e14db71d3dcd99332a9d5fe24a /xen/include/asm-arm | |
parent | acf2d315202587e81bb7f3b6841dcfce2814415e (diff) | |
download | xen-33daac3995d49d07fec245ea22f2c093fb11bec2.tar.gz xen-33daac3995d49d07fec245ea22f2c093fb11bec2.tar.bz2 xen-33daac3995d49d07fec245ea22f2c093fb11bec2.zip |
xen: remove evtchn_upcall_mask from interface on ARM
On ARM event-channel upcalls are masked using the hardware's interrupt mask
bit and not by a software bit.
Leaving this field present in the interface has caused some confusion already
and is liable to mean it gets inadvertently used in the future. So arrange for
this field to be turned into a padding field on ARM by introducing a
XEN_HAVE_PV_UPCALL_MASK define.
This bit is also unused for x86 PV-on-HVM guests, but we can't realistically
distinguish those from x86 PV guests in the headers.
Add a per-arch vcpu_event_delivery_is_enabled function to replace an open
coded use of evtchn_upcall_mask in common code (in a debug keyhandler). The
existing local_event_delivery_is_enabled, which operates only on current, was
unimplemented on ARM and unused on x86, so remove it.
ifdef the use of evtchn_upcall_mask when setting up a new vcpu info page.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Diffstat (limited to 'xen/include/asm-arm')
-rw-r--r-- | xen/include/asm-arm/event.h | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/xen/include/asm-arm/event.h b/xen/include/asm-arm/event.h index ed05901102..04d854fa62 100644 --- a/xen/include/asm-arm/event.h +++ b/xen/include/asm-arm/event.h @@ -7,6 +7,12 @@ void vcpu_kick(struct vcpu *v); void vcpu_mark_events_pending(struct vcpu *v); +static inline int vcpu_event_delivery_is_enabled(struct vcpu *v) +{ + struct cpu_user_regs *regs = &v->arch.cpu_info->guest_cpu_user_regs; + return !(regs->cpsr & PSR_IRQ_MASK); +} + static inline int local_events_need_delivery_nomask(void) { struct pending_irq *p = irq_to_pending(current, VGIC_IRQ_EVTCHN_CALLBACK); @@ -31,16 +37,11 @@ static inline int local_events_need_delivery_nomask(void) static inline int local_events_need_delivery(void) { - struct cpu_user_regs *regs = guest_cpu_user_regs(); - - /* guest IRQs are masked */ - if ( (regs->cpsr & PSR_IRQ_MASK) ) + if ( !vcpu_event_delivery_is_enabled(current) ) return 0; return local_events_need_delivery_nomask(); } -int local_event_delivery_is_enabled(void); - static inline void local_event_delivery_enable(void) { struct cpu_user_regs *regs = guest_cpu_user_regs(); |