diff options
| author | Tim Deegan <tim@xen.org> | 2013-09-12 12:36:04 +0100 |
|---|---|---|
| committer | Tim Deegan <tim@xen.org> | 2013-09-12 17:47:08 +0100 |
| commit | 803f9a6cdfeda64beee908576de0ad02d6b0c480 (patch) | |
| tree | 6000e4aadb96e23bac22ed8c5b58b40e8514e107 /xen/drivers | |
| parent | 2c40a7fa1cd5c693c424515c7c896e1a5a880bf5 (diff) | |
| download | xen-803f9a6cdfeda64beee908576de0ad02d6b0c480.tar.gz xen-803f9a6cdfeda64beee908576de0ad02d6b0c480.tar.bz2 xen-803f9a6cdfeda64beee908576de0ad02d6b0c480.zip | |
cpufreq: missing check of copy_from_guest()
Coverity CID 1055131
Coverity CID 1055132
Signed-off-by: Tim Deegan <tim@xen.org>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Diffstat (limited to 'xen/drivers')
| -rw-r--r-- | xen/drivers/cpufreq/cpufreq.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index 0de5d41d44..ab66884797 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -471,8 +471,12 @@ int set_px_pminfo(uint32_t acpi_id, struct xen_processor_performance *dom0_px_in ret = -ENOMEM; goto out; } - copy_from_guest(pxpt->states, dom0_px_info->states, - dom0_px_info->state_count); + if ( copy_from_guest(pxpt->states, dom0_px_info->states, + dom0_px_info->state_count) ) + { + ret = -EFAULT; + goto out; + } pxpt->state_count = dom0_px_info->state_count; if ( cpufreq_verbose ) |