diff options
author | Jan Beulich <jbeulich@suse.com> | 2012-09-21 14:25:12 +0200 |
---|---|---|
committer | Jan Beulich <jbeulich@suse.com> | 2012-09-21 14:25:12 +0200 |
commit | 8a858447e93a080c8f46dfd5224f6952122da05f (patch) | |
tree | a9f63a18e565e4d784374274cdd7b0c80fbfbbdb /xen/drivers/acpi | |
parent | 724b55f48a6c9fca00ddeeca5a130657680caf0b (diff) | |
download | xen-8a858447e93a080c8f46dfd5224f6952122da05f.tar.gz xen-8a858447e93a080c8f46dfd5224f6952122da05f.tar.bz2 xen-8a858447e93a080c8f46dfd5224f6952122da05f.zip |
printk: prefer %#x et at over 0x%x
Performance is not an issue with printk(), so let the function do
minimally more work and instead save a byte per affected format
specifier.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Diffstat (limited to 'xen/drivers/acpi')
-rw-r--r-- | xen/drivers/acpi/numa.c | 6 | ||||
-rw-r--r-- | xen/drivers/acpi/tables.c | 14 | ||||
-rw-r--r-- | xen/drivers/acpi/utilities/utglobal.c | 2 |
3 files changed, 11 insertions, 11 deletions
diff --git a/xen/drivers/acpi/numa.c b/xen/drivers/acpi/numa.c index ff99ffcfc6..775537b8be 100644 --- a/xen/drivers/acpi/numa.c +++ b/xen/drivers/acpi/numa.c @@ -78,8 +78,8 @@ void __init acpi_table_print_srat_entry(struct acpi_subtable_header * header) if (srat_rev < 2) proximity_domain &= 0xff; ACPI_DEBUG_PRINT((ACPI_DB_INFO, - "SRAT Memory (%#016"PRIx64 - " length %#016"PRIx64")" + "SRAT Memory (%#"PRIx64 + " length %#"PRIx64")" " in proximity domain %d %s%s\n", p->base_address, p->length, proximity_domain, @@ -108,7 +108,7 @@ void __init acpi_table_print_srat_entry(struct acpi_subtable_header * header) break; default: printk(KERN_WARNING PREFIX - "Found unsupported SRAT entry (type = 0x%x)\n", + "Found unsupported SRAT entry (type = %#x)\n", header->type); break; } diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c index a0e9c163a8..d70ffecdde 100644 --- a/xen/drivers/acpi/tables.c +++ b/xen/drivers/acpi/tables.c @@ -95,7 +95,7 @@ void __init acpi_table_print_madt_entry(struct acpi_subtable_header *header) if (p->inti_flags & ~(ACPI_MADT_POLARITY_MASK | ACPI_MADT_TRIGGER_MASK)) printk(KERN_INFO PREFIX - "INT_SRC_OVR unexpected reserved flags: 0x%x\n", + "INT_SRC_OVR unexpected reserved flags: %#x\n", p->inti_flags & ~(ACPI_MADT_POLARITY_MASK | ACPI_MADT_TRIGGER_MASK)); @@ -119,7 +119,7 @@ void __init acpi_table_print_madt_entry(struct acpi_subtable_header *header) struct acpi_madt_local_apic_nmi *p = (struct acpi_madt_local_apic_nmi *)header; printk(KERN_INFO PREFIX - "LAPIC_NMI (acpi_id[0x%02x] %s %s lint[0x%x])\n", + "LAPIC_NMI (acpi_id[0x%02x] %s %s lint[%#x])\n", p->processor_id, mps_inti_flags_polarity[p->inti_flags & ACPI_MADT_POLARITY_MASK ], mps_inti_flags_trigger[(p->inti_flags & ACPI_MADT_TRIGGER_MASK) >> 2], @@ -137,7 +137,7 @@ void __init acpi_table_print_madt_entry(struct acpi_subtable_header *header) trigger = (p->inti_flags & ACPI_MADT_TRIGGER_MASK) >> 2; printk(KERN_INFO PREFIX - "X2APIC_NMI (uid[0x%02x] %s %s lint[0x%x])\n", + "X2APIC_NMI (uid[0x%02x] %s %s lint[%#x])\n", p->uid, mps_inti_flags_polarity[polarity], mps_inti_flags_trigger[trigger], @@ -160,7 +160,7 @@ void __init acpi_table_print_madt_entry(struct acpi_subtable_header *header) struct acpi_madt_io_sapic *p = (struct acpi_madt_io_sapic *)header; printk(KERN_INFO PREFIX - "IOSAPIC (id[0x%x] address[%p] gsi_base[%d])\n", + "IOSAPIC (id[%#x] address[%p] gsi_base[%d])\n", p->id, (void *)(unsigned long)p->address, p->global_irq_base); } @@ -182,7 +182,7 @@ void __init acpi_table_print_madt_entry(struct acpi_subtable_header *header) struct acpi_madt_interrupt_source *p = (struct acpi_madt_interrupt_source *)header; printk(KERN_INFO PREFIX - "PLAT_INT_SRC (%s %s type[0x%x] id[0x%04x] eid[0x%x] iosapic_vector[0x%x] global_irq[0x%x]\n", + "PLAT_INT_SRC (%s %s type[%#x] id[0x%04x] eid[%#x] iosapic_vector[%#x] global_irq[%#x]\n", mps_inti_flags_polarity[p->inti_flags & ACPI_MADT_POLARITY_MASK], mps_inti_flags_trigger[(p->inti_flags & ACPI_MADT_TRIGGER_MASK) >> 2], p->type, p->id, p->eid, p->io_sapic_vector, @@ -192,7 +192,7 @@ void __init acpi_table_print_madt_entry(struct acpi_subtable_header *header) default: printk(KERN_WARNING PREFIX - "Found unsupported MADT entry (type = 0x%x)\n", + "Found unsupported MADT entry (type = %#x)\n", header->type); break; } @@ -242,7 +242,7 @@ acpi_table_parse_entries(char *id, ((unsigned long)entry + entry->length); } if (max_entries && count > max_entries) { - printk(KERN_WARNING PREFIX "[%4.4s:0x%02x] ignored %i entries of " + printk(KERN_WARNING PREFIX "[%4.4s:%#x] ignored %i entries of " "%i found\n", id, entry_id, count - max_entries, count); } diff --git a/xen/drivers/acpi/utilities/utglobal.c b/xen/drivers/acpi/utilities/utglobal.c index c5517e9298..7dbc964664 100644 --- a/xen/drivers/acpi/utilities/utglobal.c +++ b/xen/drivers/acpi/utilities/utglobal.c @@ -79,7 +79,7 @@ const char *__init acpi_format_exception(acpi_status status) /* Exception code was not recognized */ ACPI_ERROR((AE_INFO, - "Unknown exception code: 0x%8.8X", status)); + "Unknown exception code: %#X", status)); exception = "UNKNOWN_STATUS_CODE"; dump_execution_state(); |