diff options
| author | kfraser@localhost.localdomain <kfraser@localhost.localdomain> | 2007-01-29 10:52:17 +0000 |
|---|---|---|
| committer | kfraser@localhost.localdomain <kfraser@localhost.localdomain> | 2007-01-29 10:52:17 +0000 |
| commit | 45ce6547e6bde8cdf8f3dcaba833a3bda8f3c889 (patch) | |
| tree | 9ce439909a9e3816fbac7b29bac84009fced953e /xen/common/libelf | |
| parent | c642ec17d0d541835334b676e972539fdd5becdc (diff) | |
| download | xen-45ce6547e6bde8cdf8f3dcaba833a3bda8f3c889.tar.gz xen-45ce6547e6bde8cdf8f3dcaba833a3bda8f3c889.tar.bz2 xen-45ce6547e6bde8cdf8f3dcaba833a3bda8f3c889.zip | |
Replace sprintf with snprintf and strncpy with strlcpy.
There are various cases where no NULL-terminated strings are
guaranteed and eventual possible overflows. This patch fixes them.
From: Christoph Egger <Christoph.Egger@amd.com>
Signed-off-by: Keir Fraser <keir@xensource.com>
Diffstat (limited to 'xen/common/libelf')
| -rw-r--r-- | xen/common/libelf/libelf-dominfo.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/xen/common/libelf/libelf-dominfo.c b/xen/common/libelf/libelf-dominfo.c index c19339ab01..d3ddcdb6fe 100644 --- a/xen/common/libelf/libelf-dominfo.c +++ b/xen/common/libelf/libelf-dominfo.c @@ -128,16 +128,16 @@ int elf_xen_parse_note(struct elf_binary *elf, switch (type) { case XEN_ELFNOTE_LOADER: - strncpy(parms->loader, str, sizeof(parms->loader)); + strlcpy(parms->loader, str, sizeof(parms->loader)); break; case XEN_ELFNOTE_GUEST_OS: - strncpy(parms->guest_os, str, sizeof(parms->guest_os)); + strlcpy(parms->guest_os, str, sizeof(parms->guest_os)); break; case XEN_ELFNOTE_GUEST_VERSION: - strncpy(parms->guest_ver, str, sizeof(parms->guest_ver)); + strlcpy(parms->guest_ver, str, sizeof(parms->guest_ver)); break; case XEN_ELFNOTE_XEN_VERSION: - strncpy(parms->xen_ver, str, sizeof(parms->xen_ver)); + strlcpy(parms->xen_ver, str, sizeof(parms->xen_ver)); break; case XEN_ELFNOTE_PAE_MODE: if (0 == strcmp(str, "yes")) @@ -224,13 +224,13 @@ int elf_xen_parse_guest_info(struct elf_binary *elf, /* strings */ if (0 == strcmp(name, "LOADER")) - strncpy(parms->loader, value, sizeof(parms->loader)); + strlcpy(parms->loader, value, sizeof(parms->loader)); if (0 == strcmp(name, "GUEST_OS")) - strncpy(parms->guest_os, value, sizeof(parms->guest_os)); + strlcpy(parms->guest_os, value, sizeof(parms->guest_os)); if (0 == strcmp(name, "GUEST_VER")) - strncpy(parms->guest_ver, value, sizeof(parms->guest_ver)); + strlcpy(parms->guest_ver, value, sizeof(parms->guest_ver)); if (0 == strcmp(name, "XEN_VER")) - strncpy(parms->xen_ver, value, sizeof(parms->xen_ver)); + strlcpy(parms->xen_ver, value, sizeof(parms->xen_ver)); if (0 == strcmp(name, "PAE")) { if (0 == strcmp(value, "yes[extended-cr3]")) |