diff options
| author | Jan Beulich <jbeulich@suse.com> | 2012-09-21 14:25:12 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2012-09-21 14:25:12 +0200 |
| commit | 8a858447e93a080c8f46dfd5224f6952122da05f (patch) | |
| tree | a9f63a18e565e4d784374274cdd7b0c80fbfbbdb /xen/arch/x86/mm | |
| parent | 724b55f48a6c9fca00ddeeca5a130657680caf0b (diff) | |
| download | xen-8a858447e93a080c8f46dfd5224f6952122da05f.tar.gz xen-8a858447e93a080c8f46dfd5224f6952122da05f.tar.bz2 xen-8a858447e93a080c8f46dfd5224f6952122da05f.zip | |
printk: prefer %#x et at over 0x%x
Performance is not an issue with printk(), so let the function do
minimally more work and instead save a byte per affected format
specifier.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Diffstat (limited to 'xen/arch/x86/mm')
| -rw-r--r-- | xen/arch/x86/mm/hap/nested_hap.c | 2 | ||||
| -rw-r--r-- | xen/arch/x86/mm/p2m-pt.c | 4 | ||||
| -rw-r--r-- | xen/arch/x86/mm/shadow/common.c | 6 | ||||
| -rw-r--r-- | xen/arch/x86/mm/shadow/multi.c | 2 |
4 files changed, 7 insertions, 7 deletions
diff --git a/xen/arch/x86/mm/hap/nested_hap.c b/xen/arch/x86/mm/hap/nested_hap.c index 91f3ecaa52..317875d682 100644 --- a/xen/arch/x86/mm/hap/nested_hap.c +++ b/xen/arch/x86/mm/hap/nested_hap.c @@ -129,7 +129,7 @@ nestedhap_fix_p2m(struct vcpu *v, struct p2m_domain *p2m, if (rv == 0) { gdprintk(XENLOG_ERR, - "failed to set entry for 0x%"PRIx64" -> 0x%"PRIx64"\n", + "failed to set entry for %#"PRIx64" -> %#"PRIx64"\n", L2_gpa, L0_gpa); BUG(); } diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c index bf432c2794..9cb551d64d 100644 --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -110,8 +110,8 @@ p2m_find_entry(void *table, unsigned long *gfn_remainder, index = *gfn_remainder >> shift; if ( index >= max ) { - P2M_DEBUG("gfn=0x%lx out of range " - "(gfn_remainder=0x%lx shift=%d index=0x%x max=0x%x)\n", + P2M_DEBUG("gfn=%#lx out of range " + "(gfn_remainder=%#lx shift=%d index=%#x max=%#x)\n", gfn, *gfn_remainder, shift, index, max); return NULL; } diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c index 224e4eb1c0..3f8ad8838f 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -872,7 +872,7 @@ static int sh_skip_sync(struct vcpu *v, mfn_t gl1mfn) return SHADOW_INTERNAL_NAME(sh_safe_not_to_sync, 3)(v, gl1mfn); else if ( pg->shadow_flags & SHF_L1_64 ) return SHADOW_INTERNAL_NAME(sh_safe_not_to_sync, 4)(v, gl1mfn); - SHADOW_ERROR("gmfn 0x%lx was OOS but not shadowed as an l1.\n", + SHADOW_ERROR("gmfn %#lx was OOS but not shadowed as an l1.\n", mfn_x(gl1mfn)); BUG(); return 0; /* BUG() is no longer __attribute__((noreturn)). */ @@ -2596,8 +2596,8 @@ void sh_remove_shadows(struct vcpu *v, mfn_t gmfn, int fast, int all) smfn = shadow_hash_lookup(v, mfn_x(gmfn), t); \ if ( unlikely(!mfn_valid(smfn)) ) \ { \ - SHADOW_ERROR(": gmfn %#lx has flags 0x%"PRIx32 \ - " but no type-0x%"PRIx32" shadow\n", \ + SHADOW_ERROR(": gmfn %#lx has flags %#"PRIx32 \ + " but no type-%#"PRIx32" shadow\n", \ mfn_x(gmfn), (uint32_t)pg->shadow_flags, t); \ break; \ } \ diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index f5a8965656..b0e6d72281 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -2171,7 +2171,7 @@ static int validate_gl4e(struct vcpu *v, void *new_ge, mfn_t sl4mfn, void *se) // attempt by the guest to write to a xen reserved slot // SHADOW_PRINTK("%s out-of-range update " - "sl4mfn=%05lx index=0x%x val=%" SH_PRI_pte "\n", + "sl4mfn=%05lx index=%#x val=%" SH_PRI_pte "\n", __func__, mfn_x(sl4mfn), shadow_index, new_sl4e.l4); if ( shadow_l4e_get_flags(new_sl4e) & _PAGE_PRESENT ) { |