diff options
author | Jan Beulich <jbeulich@novell.com> | 2011-07-01 20:43:02 +0100 |
---|---|---|
committer | Jan Beulich <jbeulich@novell.com> | 2011-07-01 20:43:02 +0100 |
commit | 9e71918d4f039e5e4806493bd3310c8ceecedd08 (patch) | |
tree | 8015fe99eb1aaf119676d632d032245c7cef1ed8 /xen/arch/x86/irq.c | |
parent | 8fa9467a783e1655f4fbb12ca1f48d659115a2ea (diff) | |
download | xen-9e71918d4f039e5e4806493bd3310c8ceecedd08.tar.gz xen-9e71918d4f039e5e4806493bd3310c8ceecedd08.tar.bz2 xen-9e71918d4f039e5e4806493bd3310c8ceecedd08.zip |
x86: adjust pirq_spin_lock_irq_desc()
Remove unnecessary/bogus assertions and add retry loop matching
domain_spin_lock_irq_desc().
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Diffstat (limited to 'xen/arch/x86/irq.c')
-rw-r--r-- | xen/arch/x86/irq.c | 23 |
1 files changed, 12 insertions, 11 deletions
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index f3cb34a7ee..b46fa9b8cb 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -968,30 +968,31 @@ struct irq_desc *domain_spin_lock_irq_desc( } /* - * Same with struct pirq already looked up, and d->event_lock already - * held (thus the PIRQ <-> IRQ mapping can't change under our feet). + * Same with struct pirq already looked up. */ struct irq_desc *pirq_spin_lock_irq_desc( struct domain *d, const struct pirq *pirq, unsigned long *pflags) { - int irq = pirq->arch.irq; struct irq_desc *desc; unsigned long flags; - ASSERT(spin_is_locked(&d->event_lock)); + for ( ; ; ) + { + int irq = pirq->arch.irq; - if ( irq <= 0 ) - return NULL; + if ( irq <= 0 ) + return NULL; - desc = irq_to_desc(irq); - spin_lock_irqsave(&desc->lock, flags); + desc = irq_to_desc(irq); + spin_lock_irqsave(&desc->lock, flags); + if ( irq == pirq->arch.irq ) + break; + spin_unlock_irqrestore(&desc->lock, flags); + } if ( pflags ) *pflags = flags; - ASSERT(pirq == pirq_info(d, domain_irq_to_pirq(d, irq))); - ASSERT(irq == pirq->arch.irq); - return desc; } |