diff options
author | Jan Beulich <jbeulich@suse.com> | 2011-11-18 09:21:24 +0100 |
---|---|---|
committer | Jan Beulich <jbeulich@suse.com> | 2011-11-18 09:21:24 +0100 |
commit | 8eca0db0e836a081d873de7e9eefb3763f065780 (patch) | |
tree | 3d1de8742a3c35ef7ce3184bb2d1712f49da826f /xen/arch/x86/irq.c | |
parent | f0b7583fd5a6ea317637693138e060a263b94a2c (diff) | |
download | xen-8eca0db0e836a081d873de7e9eefb3763f065780.tar.gz xen-8eca0db0e836a081d873de7e9eefb3763f065780.tar.bz2 xen-8eca0db0e836a081d873de7e9eefb3763f065780.zip |
x86/IRQ: prevent vector sharing within IO-APICs
Following the prevention of vector sharing for MSIs, this change
enforces the same within IO-APICs: Pin based interrupts use the IO-APIC
as their identifying device under the AMD IOMMU (and just like for
MSIs, only the identifying device is used to remap interrupts here,
with no regard to an interrupt's destination).
Additionally, LAPIC initiated EOIs (for level triggered interrupts) too
use only the vector for identifying which interrupts to end. While this
generally causes no significant problem (at worst an interrupt would be
re-raised without a new interrupt event actually having occurred), it
still seems better to avoid the situation.
For this second aspect, a distinction is being made between the
traditional and the directed-EOI cases: In the former, vectors should
not be shared throughout all IO-APICs in the system, while in the
latter case only individual IO-APICs need to be contrained (or, if the
firmware indicates so, sub- groups of them having the same GSI appear
at multiple pins).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Diffstat (limited to 'xen/arch/x86/irq.c')
-rw-r--r-- | xen/arch/x86/irq.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index c525c51b8e..9149096507 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -395,6 +395,11 @@ static vmask_t *irq_get_used_vector_mask(int irq) } } } + else if ( IO_APIC_IRQ(irq) && + opt_irq_vector_map != OPT_IRQ_VECTOR_MAP_NONE ) + { + ret = io_apic_get_used_vector_map(irq); + } return ret; } |