aboutsummaryrefslogtreecommitdiffstats
path: root/xen/arch/x86/irq.c
diff options
context:
space:
mode:
authorJan Beulich <jbeulich@suse.com>2012-02-16 08:48:23 +0100
committerJan Beulich <jbeulich@suse.com>2012-02-16 08:48:23 +0100
commit819e844385469bf8933d245fdb63b6e4727bfb09 (patch)
treeb82d2851fe6136f1de887b25cd3e5187e035444d /xen/arch/x86/irq.c
parent5c4e1c1b482e7fdf08d42447b4ea054a977e187c (diff)
downloadxen-819e844385469bf8933d245fdb63b6e4727bfb09.tar.gz
xen-819e844385469bf8933d245fdb63b6e4727bfb09.tar.bz2
xen-819e844385469bf8933d245fdb63b6e4727bfb09.zip
replace bogus gdprintk() uses with {,d}printk()
When the subject domain is not the current one (e.g. during domctl or HVM save/restore handling), use of gdprintk() is questionable at best, as it won't give the intended information on what domain is affected. Use plain printk() or dprintk() instead, but keep things (mostly) as guest messages by using XENLOG_G_*. Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Keir Fraser <keir@xen.org>
Diffstat (limited to 'xen/arch/x86/irq.c')
-rw-r--r--xen/arch/x86/irq.c26
1 files changed, 13 insertions, 13 deletions
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index e9e1a9e552..0e5b9c0de0 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -1517,9 +1517,9 @@ int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share)
{
if ( desc->action != NULL )
{
- gdprintk(XENLOG_INFO,
- "Cannot bind IRQ %d to guest. In use by '%s'.\n",
- pirq->pirq, desc->action->name);
+ printk(XENLOG_G_INFO
+ "Cannot bind IRQ%d to dom%d. In use by '%s'.\n",
+ pirq->pirq, v->domain->domain_id, desc->action->name);
rc = -EBUSY;
goto unlock_out;
}
@@ -1531,9 +1531,9 @@ int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share)
zalloc_cpumask_var(&newaction->cpu_eoi_map) )
goto retry;
xfree(newaction);
- gdprintk(XENLOG_INFO,
- "Cannot bind IRQ %d to guest. Out of memory.\n",
- pirq->pirq);
+ printk(XENLOG_G_INFO
+ "Cannot bind IRQ%d to dom%d. Out of memory.\n",
+ pirq->pirq, v->domain->domain_id);
rc = -ENOMEM;
goto out;
}
@@ -1558,11 +1558,10 @@ int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share)
}
else if ( !will_share || !action->shareable )
{
- gdprintk(XENLOG_INFO, "Cannot bind IRQ %d to guest. %s.\n",
- pirq->pirq,
- will_share ?
- "Others do not share" :
- "Will not share with others");
+ printk(XENLOG_G_INFO "Cannot bind IRQ%d to dom%d. %s.\n",
+ pirq->pirq, v->domain->domain_id,
+ will_share ? "Others do not share"
+ : "Will not share with others");
rc = -EBUSY;
goto unlock_out;
}
@@ -1581,8 +1580,9 @@ int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share)
if ( action->nr_guests == IRQ_MAX_GUESTS )
{
- gdprintk(XENLOG_INFO, "Cannot bind IRQ %d to guest. "
- "Already at max share.\n", pirq->pirq);
+ printk(XENLOG_G_INFO "Cannot bind IRQ%d to dom%d. "
+ "Already at max share.\n",
+ pirq->pirq, v->domain->domain_id);
rc = -EBUSY;
goto unlock_out;
}