Pass cpumasks by reference always.

Rather than passing cpumasks by value in all cases (which is
problematic for large NR_CPUS configurations), pass them 'by
reference' (i.e. through a pointer to a const cpumask).

On x86 this changes send_IPI_mask() to always only send IPIs to remote
CPUs (meaning any caller needing to handle the current CPU as well has
to do so on its own).

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Keir Fraser <keir.fraser@citrix.com>

1 files changed, 0 insertions, 14 deletions

diff --git a/xen/arch/x86/crash.c b/xen/arch/x86/crash.c
index d38f969d02..009ae9ab7e 100644
--- a/xen/arch/x86/crash.c
+++ b/xen/arch/x86/crash.c
@@ -13,7 +13,6 @@
 #include <asm/percpu.h>
 #include <xen/types.h>
 #include <xen/irq.h>
-#include <asm/ipi.h>
 #include <asm/nmi.h>
 #include <xen/string.h>
 #include <xen/elf.h>
@@ -51,19 +50,6 @@ static int crash_nmi_callback(struct cpu_user_regs *regs, int cpu)
     return 1;
 }
 
-/*
- * By using the NMI code instead of a vector we just sneak thru the
- * word generator coming out with just what we want.  AND it does
- * not matter if clustered_apic_mode is set or not.
- */
-static void smp_send_nmi_allbutself(void)
-{
-    cpumask_t allbutself = cpu_online_map;
-    cpu_clear(smp_processor_id(), allbutself);
-    if ( !cpus_empty(allbutself) )
-        send_IPI_mask(allbutself, APIC_DM_NMI);
-}
-
 static void nmi_shootdown_cpus(void)
 {
     unsigned long msecs;