aboutsummaryrefslogtreecommitdiffstats
path: root/xen/arch/x86/apic.c
diff options
context:
space:
mode:
authorKeir Fraser <keir@xen.org>2010-11-15 09:31:38 +0000
committerKeir Fraser <keir@xen.org>2010-11-15 09:31:38 +0000
commit2988e3b9d23d67053eff5309e14b8d0ae1ba8591 (patch)
treeaa818c8d489502b84e5b8330ad128838b08d2ce6 /xen/arch/x86/apic.c
parent9a36faf0c63bbb898d26f2114f0cb71b723f66c9 (diff)
downloadxen-2988e3b9d23d67053eff5309e14b8d0ae1ba8591.tar.gz
xen-2988e3b9d23d67053eff5309e14b8d0ae1ba8591.tar.bz2
xen-2988e3b9d23d67053eff5309e14b8d0ae1ba8591.zip
x2apic: Remove a panic condition in enabling x2APIC
Currently Xen triggers a panic if user disables VT-d by command line while not disable x2APIC. This requires users to specify both "iommu=0" and "x2apic=0" to disable VT-d if the platform supports x2APIC. It's not user friendly. This patch removes the panic condition. That's to say, don't require user to specify "x2apic=0" when specify "iommu=0". As long as VT-d is not enabled (disabled in BIOS or in command line), x2APIC won't be enabled naturally (x2APIC depends on VT-d Interrupt remapping). Signed-off-by: Weidong Han <weidong.han@intel.com>
Diffstat (limited to 'xen/arch/x86/apic.c')
-rw-r--r--xen/arch/x86/apic.c21
1 files changed, 5 insertions, 16 deletions
diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c
index 7c1913a18e..8329da1930 100644
--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -1009,22 +1009,11 @@ static void enable_bsp_x2apic(void)
}
else
{
- if ( !iommu_enabled || !iommu_intremap || !iommu_qinval )
- panic("Cannot enable x2APIC due to iommu or interrupt "
- "remapping or queued invalidation is disabled "
- "by command line!\n");
- else
- {
- if ( x2apic_preenabled )
- panic("x2APIC: already enabled by BIOS, but "
- "iommu_supports_eim fails\n");
- else
- {
- printk("Not enable x2APIC due to "
- "iommu_supports_eim fails!\n");
- return;
- }
- }
+ if ( x2apic_preenabled )
+ panic("x2APIC: already enabled by BIOS, but "
+ "iommu_supports_eim failed!\n");
+ printk("Not enabling x2APIC: depends oniommu_supports_eim\n");
+ return;
}
}