diff options
| author | Keir Fraser <keir.fraser@citrix.com> | 2009-03-31 13:22:12 +0100 |
|---|---|---|
| committer | Keir Fraser <keir.fraser@citrix.com> | 2009-03-31 13:22:12 +0100 |
| commit | ed25dad906fd3bec60fa79bc124afb3e854d67f0 (patch) | |
| tree | 02e99908dcbdf1f865a74dbb7ba0c592211bb15e /xen/arch/x86/Rules.mk | |
| parent | 3f64466b4bfbc47a9cb97416d7ed883606a329d2 (diff) | |
| download | xen-ed25dad906fd3bec60fa79bc124afb3e854d67f0.tar.gz xen-ed25dad906fd3bec60fa79bc124afb3e854d67f0.tar.bz2 xen-ed25dad906fd3bec60fa79bc124afb3e854d67f0.zip | |
Use unlikely() in BUG_ON()/WARN_ON()
-fno-reorder-blocks was added in c/s 1712, when x86-64 just started to
become enabled. The reason it got added is entirely unclear to me, and
it prevents the intended effect of unlikely() constructs (in
particular
the ones added here) of moving out of line code which is expected to
never get executed, as well as using forward branches (which are
statically predicted taken by various processors' branch prediction
units) preferably to reach infrequently executed code.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Diffstat (limited to 'xen/arch/x86/Rules.mk')
| -rw-r--r-- | xen/arch/x86/Rules.mk | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xen/arch/x86/Rules.mk b/xen/arch/x86/Rules.mk index e9e1d5b952..d97cea4777 100644 --- a/xen/arch/x86/Rules.mk +++ b/xen/arch/x86/Rules.mk @@ -42,7 +42,7 @@ x86_64 := n endif ifeq ($(TARGET_SUBARCH),x86_64) -CFLAGS += -mno-red-zone -fpic -fno-reorder-blocks +CFLAGS += -mno-red-zone -fpic CFLAGS += -fno-asynchronous-unwind-tables # -fvisibility=hidden reduces -fpic cost, if it's available ifneq ($(call cc-option,$(CC),-fvisibility=hidden,n),n) |