diff options
author | Keir Fraser <keir.fraser@citrix.com> | 2009-05-07 19:32:10 +0100 |
---|---|---|
committer | Keir Fraser <keir.fraser@citrix.com> | 2009-05-07 19:32:10 +0100 |
commit | 727a00e80e581ee15ea2b7caea3fe27c415164f5 (patch) | |
tree | b0b2c380052ec215eaa5ea867024e9a8173ac70d /tools | |
parent | ca8d042e26e9b6e98e2b6bfcbba0c8025e135012 (diff) | |
download | xen-727a00e80e581ee15ea2b7caea3fe27c415164f5.tar.gz xen-727a00e80e581ee15ea2b7caea3fe27c415164f5.tar.bz2 xen-727a00e80e581ee15ea2b7caea3fe27c415164f5.zip |
Permit user to suppress passing --prefix to setup.py
We change all invocations of setup.py as follows:
* use $(PYTHON) instead of `python' so that the user can specify
an alternative python version if they need to. If not set it
defaults to `python' in Config.mk.
* pass --prefix=$(PREFIX) via a new make variable
$(PYTHON_PREFIX_ARG). This allows a user to suppress the
--prefix=... argument entirely by setting PYTHON_PREFIX_ARG=''.
This will work around the bug described here
https://bugs.launchpad.net/ubuntu/+bug/362570
where passing --prefix=/usr/local (which ought to have no effect as
/usr/local is the default prefix) changes which subdirectory
distutils chooses, and results in the files being installed in
site-packages which is not on the default search path.
Users not affected by this python packaging bug should not set
PYTHON_PREFIX_ARG and their builds will not be affected. (Provided
PREFIX did not contain spaces. People who put spaces in PREFIX are
being quite optimistic.)
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/pygrub/Makefile | 6 | ||||
-rw-r--r-- | tools/python/Makefile | 6 | ||||
-rw-r--r-- | tools/security/Makefile | 6 |
3 files changed, 9 insertions, 9 deletions
diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile index 0791012e2a..b8b64a7794 100644 --- a/tools/pygrub/Makefile +++ b/tools/pygrub/Makefile @@ -6,12 +6,12 @@ include $(XEN_ROOT)/tools/Rules.mk all: build .PHONY: build build: - CC="$(CC)" CFLAGS="$(CFLAGS)" python setup.py build + CC="$(CC)" CFLAGS="$(CFLAGS)" $(PYTHON) setup.py build .PHONY: install install: all - CC="$(CC)" CFLAGS="$(CFLAGS)" python setup.py install \ - --prefix="$(PREFIX)" --root="$(DESTDIR)" --force + CC="$(CC)" CFLAGS="$(CFLAGS)" $(PYTHON) setup.py install \ + $(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" --force $(INSTALL_DIR) $(DESTDIR)/var/run/xend/boot .PHONY: clean diff --git a/tools/python/Makefile b/tools/python/Makefile index cbc3973d02..16ab59fd51 100644 --- a/tools/python/Makefile +++ b/tools/python/Makefile @@ -16,7 +16,7 @@ NLSDIR = $(SHAREDIR)/locale .PHONY: build buildpy buildpy: - CC="$(CC)" CFLAGS="$(CFLAGS)" python setup.py build + CC="$(CC)" CFLAGS="$(CFLAGS)" $(PYTHON) setup.py build build: buildpy refresh-pot refresh-po $(CATALOGS) @@ -55,8 +55,8 @@ refresh-po: $(POTFILE) .PHONY: install install: install-messages install-dtd - CC="$(CC)" CFLAGS="$(CFLAGS)" python setup.py install \ - --prefix="$(PREFIX)" --root="$(DESTDIR)" --force + CC="$(CC)" CFLAGS="$(CFLAGS)" $(PYTHON) setup.py install \ + $(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" --force install-dtd: all $(INSTALL_DIR) $(DESTDIR)$(DOCDIR) diff --git a/tools/security/Makefile b/tools/security/Makefile index 996e96599a..f8eb69c6b3 100644 --- a/tools/security/Makefile +++ b/tools/security/Makefile @@ -60,8 +60,8 @@ install: all $(ACM_CONFIG_FILE) $(INSTALL_DATA) $(ACM_INST_HTML) $(DESTDIR)$(ACM_SECGEN_HTMLDIR) $(INSTALL_DIR) $(DESTDIR)$(ACM_SECGEN_CGIDIR) $(INSTALL_PROG) $(ACM_INST_CGI) $(DESTDIR)$(ACM_SECGEN_CGIDIR) - python python/setup.py install \ - --prefix="$(PREFIX)" --root="$(DESTDIR)" --force + $(PYTHON) python/setup.py install $(PYTHON_PREFIX_ARG) \ + --root="$(DESTDIR)" --force else .PHONY: all all: @@ -72,7 +72,7 @@ endif .PHONY: build build: $(ACM_INST_TOOLS) $(ACM_NOINST_TOOLS) - python python/setup.py build + $(PYTHON) python/setup.py build chmod 700 $(ACM_SCRIPTS) xensec_tool: $(OBJS_TOOL) |