diff options
author | Roger Pau Monne <roger.pau@entel.upc.edu> | 2012-01-27 17:48:14 +0000 |
---|---|---|
committer | Roger Pau Monne <roger.pau@entel.upc.edu> | 2012-01-27 17:48:14 +0000 |
commit | ade17521489197781e655b78f2e0d30eff5b4ab6 (patch) | |
tree | 501f80551af4e5c17cc22992c1778a7f24c56154 /tools/libxl | |
parent | 34710f4a96bf73d9ef12528bffc560cf8e980ddd (diff) | |
download | xen-ade17521489197781e655b78f2e0d30eff5b4ab6.tar.gz xen-ade17521489197781e655b78f2e0d30eff5b4ab6.tar.bz2 xen-ade17521489197781e655b78f2e0d30eff5b4ab6.zip |
libxl: fix mutex initialization
The macro PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP is not defined on
NetBSD, so define mutex attributes manually.
Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
Diffstat (limited to 'tools/libxl')
-rw-r--r-- | tools/libxl/libxl.c | 9 | ||||
-rw-r--r-- | tools/libxl/libxl_internal.c | 27 | ||||
-rw-r--r-- | tools/libxl/libxl_internal.h | 2 |
3 files changed, 33 insertions, 5 deletions
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index eea14b3d6a..c11b7ca30e 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -26,7 +26,6 @@ int libxl_ctx_alloc(libxl_ctx **pctx, int version, { libxl_ctx *ctx = NULL; struct stat stat_buf; - const pthread_mutex_t mutex_value = PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP; int rc; if (version != LIBXL_VERSION) { rc = ERROR_VERSION; goto out; } @@ -40,10 +39,10 @@ int libxl_ctx_alloc(libxl_ctx **pctx, int version, memset(ctx, 0, sizeof(libxl_ctx)); ctx->lg = lg; - /* This somewhat convoluted approach is needed because - * PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP is defined to be valid - * only as an initialiser, not as an expression. */ - memcpy(&ctx->lock, &mutex_value, sizeof(ctx->lock)); + if (libxl__init_recursive_mutex(ctx, &ctx->lock) < 0) { + LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "Failed to initialize mutex"); + return ERROR_FAIL; + } LIBXL_TAILQ_INIT(&ctx->occurred); diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c index 49b0dabea7..12c32dce09 100644 --- a/tools/libxl/libxl_internal.c +++ b/tools/libxl/libxl_internal.c @@ -296,6 +296,33 @@ _hidden int libxl__compare_macs(libxl_mac *a, libxl_mac *b) return 0; } +_hidden int libxl__init_recursive_mutex(libxl_ctx *ctx, pthread_mutex_t *lock) +{ + pthread_mutexattr_t attr; + int rc = 0; + + if (pthread_mutexattr_init(&attr) != 0) { + LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, + "Failed to init mutex attributes\n"); + return ERROR_FAIL; + } + if (pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE) != 0) { + LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, + "Failed to set mutex attributes\n"); + rc = ERROR_FAIL; + goto out; + } + if (pthread_mutex_init(lock, &attr) != 0) { + LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, + "Failed to init mutex\n"); + rc = ERROR_FAIL; + goto out; + } +out: + pthread_mutexattr_destroy(&attr); + return rc; +} + libxl_device_model_version libxl__device_model_version_running(libxl__gc *gc, uint32_t domid) { diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index 3834c5c1b0..43f7b669ac 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -974,6 +974,8 @@ _hidden int libxl__e820_alloc(libxl__gc *gc, uint32_t domid, libxl_domain_config _hidden int libxl__parse_mac(const char *s, libxl_mac mac); /* compare mac address @a and @b. 0 if the same, -ve if a<b and +ve if a>b */ _hidden int libxl__compare_macs(libxl_mac *a, libxl_mac *b); +/* init a recursive mutex */ +_hidden int libxl__init_recursive_mutex(libxl_ctx *ctx, pthread_mutex_t *lock); _hidden int libxl__gettimeofday(libxl__gc *gc, struct timeval *now_r); |