diff options
author | Ian Campbell <ian.campbell@citrix.com> | 2012-04-16 16:00:47 +0100 |
---|---|---|
committer | Ian Campbell <ian.campbell@citrix.com> | 2012-04-16 16:00:47 +0100 |
commit | e601453ce6046956507df3efab03a9f767517ea5 (patch) | |
tree | 6c566b8d8bdb71a1756321f8953157e5e68bc0c4 /tools/libxl/xl_cmdtable.c | |
parent | 663448101e80c738e486e41b4d40d38a8b436123 (diff) | |
download | xen-e601453ce6046956507df3efab03a9f767517ea5.tar.gz xen-e601453ce6046956507df3efab03a9f767517ea5.tar.bz2 xen-e601453ce6046956507df3efab03a9f767517ea5.zip |
libxl: Remove libxl_tmem_destroy and associated xl command
Dan Magenheimer explains in <4c2f7fca-dda2-4598-aaab-3a6a3fe532cd@default>:
I think the tmem_destroy functionality pre-dates the
existence of tmem "freeable" memory* and was a way for
a toolset to force the hypervisor to free up the hypervisor
memory used by some or all ephemeral tmem pools. Once the
tmem allocation/free process was directly linked into
alloc_heap_pages() in the hypervisor (see call to
tmem_relinquish_pages()), this forcing function was
no longer needed.
So, bottom line, I *think* it can be ripped out, or at least
for now removed from the definition of the stable xl API/UI.
The libxl.c routine libxl_tmem_destroy() could also be
removed if you like, but I guess I'd prefer to leave the
lower level droppings in xc.c and in the hypervisor in case
I am misremembering.
Accordingly remove this interface from libxl and xl but don't touch libxc or
the hypervisor.
This is the only libxl_tmem_* function which might potentially have required
conversion to be asynchronous and which therefore might have been a potential
API stability concern.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Jackson <ian.jackson.citrix.com>
Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
Diffstat (limited to 'tools/libxl/xl_cmdtable.c')
-rw-r--r-- | tools/libxl/xl_cmdtable.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/tools/libxl/xl_cmdtable.c b/tools/libxl/xl_cmdtable.c index 736a8366ed..de8955c1fa 100644 --- a/tools/libxl/xl_cmdtable.c +++ b/tools/libxl/xl_cmdtable.c @@ -336,12 +336,6 @@ struct cmd_spec cmd_table[] = { "[<Domain>|-a]", " -a Freeze all tmem", }, - { "tmem-destroy", - &main_tmem_destroy, 0, - "Destroy tmem pools", - "[<Domain>|-a]", - " -a Destroy all tmem", - }, { "tmem-thaw", &main_tmem_thaw, 0, "Thaw tmem pools", |