diff options
| author | Ian Jackson <Ian.Jackson@eu.citrix.com> | 2010-08-17 17:20:53 +0100 |
|---|---|---|
| committer | Ian Jackson <Ian.Jackson@eu.citrix.com> | 2010-08-17 17:20:53 +0100 |
| commit | 8188bc8a37e790fd2f051c2714c2a628d10c1c5e (patch) | |
| tree | 18399ac2156175711a996e81ceebca4e16322533 /tools/libxl/libxlu_cfg_l.l | |
| parent | d83eb7f21e37956c1674481b56f0c9181d493304 (diff) | |
| download | xen-8188bc8a37e790fd2f051c2714c2a628d10c1c5e.tar.gz xen-8188bc8a37e790fd2f051c2714c2a628d10c1c5e.tar.bz2 xen-8188bc8a37e790fd2f051c2714c2a628d10c1c5e.zip | |
tools/libxl: compile with -Wmissing-declarations
Since the recent build error caused by mismatch of symbol types due to
missing declarations, build libxl with -Wmissing-declarations.
The patch is mostly straightforward, a one liner in the makefile enables
the flag, a lot of functions in xl_cmdimpl.c needed to be made static
and libxl_paths.c needed to include libxl.h.
The one wart on the patch-set is that flex has a bug where it emits code
with missing declarations for yy(set|get)_column. This can be worked
around by providing the declarations ourselves regardless.
Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Diffstat (limited to 'tools/libxl/libxlu_cfg_l.l')
| -rw-r--r-- | tools/libxl/libxlu_cfg_l.l | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/tools/libxl/libxlu_cfg_l.l b/tools/libxl/libxlu_cfg_l.l index b3700281cb..ac6b0112c2 100644 --- a/tools/libxl/libxlu_cfg_l.l +++ b/tools/libxl/libxlu_cfg_l.l @@ -11,6 +11,13 @@ return (x); \ }while(0) +/* Some versions of flex have a bug (Fedora bugzilla 612465) which causes + * it to fail to declare these functions, which it defines. So declare + * them ourselves. Hopefully we won't have to simultaneously support + * a flex version which declares these differently somehow. */ +int xlu__cfg_yyget_column(yyscan_t yyscanner); +void xlu__cfg_yyset_column(int column_no, yyscan_t yyscanner); + %} %option warn |