aboutsummaryrefslogtreecommitdiffstats
path: root/tools/libxl/libxl_exec.c
diff options
context:
space:
mode:
authorIan Campbell <Ian.Campbell@citrix.com>2012-09-17 11:17:00 +0100
committerIan Campbell <Ian.Campbell@citrix.com>2012-09-17 11:17:00 +0100
commit4de237a42e0b79c87aeaf37792be6458b5437f7b (patch)
tree0f1b0d38881aee575bdcd3ee65a0ebe500db5f81 /tools/libxl/libxl_exec.c
parent5e61076e8f6e48856dacbd65499d6cb69d31976b (diff)
downloadxen-4de237a42e0b79c87aeaf37792be6458b5437f7b.tar.gz
xen-4de237a42e0b79c87aeaf37792be6458b5437f7b.tar.bz2
xen-4de237a42e0b79c87aeaf37792be6458b5437f7b.zip
libxl: Enable -Wshadow.
It was convenient to invent $(CFLAGS_LIBXL) to do this. Various renamings to avoid shadowing standard functions: - index(3) - listen(2) - link(2) - abort(3) - abs(3) Reduced the scope of some variables to avoid conflicts. Change to libxc is due to the nested hypercall buf macros in set_xen_guest_handle (used in libxl) using the same local private vars. Build tested only. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Committed-by: Ian Campbell <ian.campbell@citrix.com>
Diffstat (limited to 'tools/libxl/libxl_exec.c')
-rw-r--r--tools/libxl/libxl_exec.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/tools/libxl/libxl_exec.c b/tools/libxl/libxl_exec.c
index 04773866e4..98bfd716ac 100644
--- a/tools/libxl/libxl_exec.c
+++ b/tools/libxl/libxl_exec.c
@@ -35,7 +35,7 @@ static void check_open_fds(const char *what)
#ifdef __linux__
size_t len;
char path[PATH_MAX];
- char link[PATH_MAX+1];
+ char linkpath[PATH_MAX+1];
#endif
flags = fcntl(i, F_GETFD);
if ( flags == -1 ) {
@@ -52,11 +52,11 @@ static void check_open_fds(const char *what)
#ifdef __linux__
snprintf(path, PATH_MAX, "/proc/%d/fd/%d", getpid(), i);
- len = readlink(path, link, PATH_MAX);
+ len = readlink(path, linkpath, PATH_MAX);
if (len > 0) {
- link[len] = '\0';
+ linkpath[len] = '\0';
fprintf(stderr, "libxl: execing %s: fd %d is open to %s with flags %#x\n",
- what, i, link, flags);
+ what, i, linkpath, flags);
} else
#endif
fprintf(stderr, "libxl: execing %s: fd %d is open with flags %#x\n",