diff options
| author | Ian Campbell <ian.campbell@citrix.com> | 2012-09-17 11:17:02 +0100 |
|---|---|---|
| committer | Ian Campbell <ian.campbell@citrix.com> | 2012-09-17 11:17:02 +0100 |
| commit | a73a7a0c647a9a5e30d8bc473c0a1e8648817183 (patch) | |
| tree | 60df841ab6f883779a94f5a91a0e2fdfe51a3f2a /tools/libxl/Makefile | |
| parent | ead2225b33dec11a4c1f638074508581df57ceab (diff) | |
| download | xen-a73a7a0c647a9a5e30d8bc473c0a1e8648817183.tar.gz xen-a73a7a0c647a9a5e30d8bc473c0a1e8648817183.tar.bz2 xen-a73a7a0c647a9a5e30d8bc473c0a1e8648817183.zip | |
xl: Remove global domid and enable -Wshadow
Lots of functions loop over a list of domain and others take a domid as
a parameter, shadowing the global one and leading to all sorts of
confusion.
Therefore remove the global domid and explicitly pass it around as
necessary.
Adds a domid to the parameters for many functions and switches many
others from taking a char * domain specifier to taking a domid, pushing
the domid lookup to the toplevel.
Replaces some open-coded domain_qualifier_to_domid error checking with
find_domain.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
[ ijc -- annotate find_domain() with warn_unused_result and fix the
handful of errors. ]
Committed-by: Ian Campbell <ian.campbell@citrix.com>
Diffstat (limited to 'tools/libxl/Makefile')
| -rw-r--r-- | tools/libxl/Makefile | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index c7ad984866..af9939ffaa 100644 --- a/tools/libxl/Makefile +++ b/tools/libxl/Makefile @@ -89,10 +89,13 @@ $(LIBXLU_OBJS): CFLAGS += $(CFLAGS_libxenctrl) # For xentoollog.h CLIENTS = xl testidl libxl-save-helper +CFLAGS_XL += $(CFLAGS_libxenlight) +CFLAGS_XL += -Wshadow + XL_OBJS = xl.o xl_cmdimpl.o xl_cmdtable.o xl_sxp.o $(XL_OBJS) _libxl.api-for-check: \ CFLAGS += $(CFLAGS_libxenctrl) # For xentoollog.h -$(XL_OBJS): CFLAGS += $(CFLAGS_libxenlight) +$(XL_OBJS): CFLAGS += $(CFLAGS_XL) $(XL_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h # libxl_json.h needs it. SAVE_HELPER_OBJS = libxl_save_helper.o _libxl_save_msgs_helper.o |