diff options
| author | kaf24@firebug.cl.cam.ac.uk <kaf24@firebug.cl.cam.ac.uk> | 2006-01-10 15:28:41 +0100 |
|---|---|---|
| committer | kaf24@firebug.cl.cam.ac.uk <kaf24@firebug.cl.cam.ac.uk> | 2006-01-10 15:28:41 +0100 |
| commit | 57ad8645a90aff77fd8c803d5cb27c213b5671aa (patch) | |
| tree | 9f157ef237553b204fc0adab218e788c44bf8a0a /tools/libxc/xg_private.c | |
| parent | 116bf770dc3f1d4cfff4eb0a4e35f9a921703dac (diff) | |
| download | xen-57ad8645a90aff77fd8c803d5cb27c213b5671aa.tar.gz xen-57ad8645a90aff77fd8c803d5cb27c213b5671aa.tar.bz2 xen-57ad8645a90aff77fd8c803d5cb27c213b5671aa.zip | |
Proactively check for NULL strings passed into xc_linx_build. Either do
the right thing or return error if detected. A NULL cmdline, for example,
would currently generate a segfault.
Signed-off-by: Ben Thomas <bjthomas3@gmail.com>
Diffstat (limited to 'tools/libxc/xg_private.c')
| -rw-r--r-- | tools/libxc/xg_private.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/libxc/xg_private.c b/tools/libxc/xg_private.c index 355ba1400d..982d8256be 100644 --- a/tools/libxc/xg_private.c +++ b/tools/libxc/xg_private.c @@ -17,6 +17,9 @@ char *xc_read_kernel_image(const char *filename, unsigned long *size) char *image = NULL; unsigned int bytes; + if ( filename == NULL ) + goto out; + if ( (kernel_fd = open(filename, O_RDONLY)) < 0 ) { PERROR("Could not open kernel image"); |