aboutsummaryrefslogtreecommitdiffstats
path: root/tools/hotplug
diff options
context:
space:
mode:
authorIan Jackson <Ian.Jackson@eu.citrix.com>2010-12-14 17:38:18 +0000
committerIan Jackson <Ian.Jackson@eu.citrix.com>2010-12-14 17:38:18 +0000
commit6e22a6ba68a6270fa2ec85feab8163bab8523c55 (patch)
treed58832a7ca5d9d8aca469b154a50862505fc33d7 /tools/hotplug
parent6250b87dcd7eef8ba59a32edc41751b833f990e0 (diff)
downloadxen-6e22a6ba68a6270fa2ec85feab8163bab8523c55.tar.gz
xen-6e22a6ba68a6270fa2ec85feab8163bab8523c55.tar.bz2
xen-6e22a6ba68a6270fa2ec85feab8163bab8523c55.zip
tools/hotplug: Do not mind if "ip link set" fails on vif backends
Most versions of netback do not support setting the MAC address. This means that c/s 937488219719 causes the hotplug script to break for vifs, even as it fixes the bridge-wrong-MAC-address problem for tap devices (used for emulated nics). The mac-setting operation is not necessary for vifs since they are hardcoded to fe:ff* anyway. As a band-aid, add "|| true" to the call to ip link, so that this error does not cause the hotplug operation to fail. There will still be an error message printed until we can fix this better. Suggested-by: Ian Campbell <Ian.Campbell@eu.citrix.com> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Diffstat (limited to 'tools/hotplug')
-rw-r--r--tools/hotplug/Linux/xen-network-common.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh
index 3157a10618..1100757c82 100644
--- a/tools/hotplug/Linux/xen-network-common.sh
+++ b/tools/hotplug/Linux/xen-network-common.sh
@@ -90,7 +90,7 @@ setup_bridge_port() {
# largest non-broadcast address to prevent the address getting
# stolen by an Ethernet bridge for STP purposes.
# (FE:FF:FF:FF:FF:FF)
- ip link set ${dev} address fe:ff:ff:ff:ff:ff
+ ip link set ${dev} address fe:ff:ff:ff:ff:ff || true
# ... and configure it
ip addr flush ${dev}