diff options
author | Ian Campbell <ian.campbell@xensource.com> | 2007-03-19 14:00:07 +0000 |
---|---|---|
committer | Ian Campbell <ian.campbell@xensource.com> | 2007-03-19 14:00:07 +0000 |
commit | 3b8a13159a7851752281ac82bef907093aea06da (patch) | |
tree | df5915a6fa75b456b1f4a1ca1bf46c7b410f66d2 /patches | |
parent | f8b68fe2dad1e6bf4f55483dd023561d3ee008cb (diff) | |
download | xen-3b8a13159a7851752281ac82bef907093aea06da.tar.gz xen-3b8a13159a7851752281ac82bef907093aea06da.tar.bz2 xen-3b8a13159a7851752281ac82bef907093aea06da.zip |
[LINUX] Update crash-kernel-32-on-64.patch with more sensible version from -mm.
The previous version had side effects outside of the crash dump code.
Signed-off-by: Ian Campbell <ian.campbell@xensource.com>
Diffstat (limited to 'patches')
4 files changed, 98 insertions, 12 deletions
diff --git a/patches/linux-2.6.18/allow-i386-crash-kernels-to-handle-x86_64-dumps-fix.patch b/patches/linux-2.6.18/allow-i386-crash-kernels-to-handle-x86_64-dumps-fix.patch new file mode 100644 index 0000000000..2d60059ca7 --- /dev/null +++ b/patches/linux-2.6.18/allow-i386-crash-kernels-to-handle-x86_64-dumps-fix.patch @@ -0,0 +1,30 @@ +From: Andrew Morton <akpm@linux-foundation.org> + +In file included from arch/i386/kernel/setup.c:46: +include/linux/crash_dump.h:19:36: warning: extra tokens at end of #ifndef directive + +Cc: "Eric W. Biederman" <ebiederm@xmission.com> +Cc: Andi Kleen <ak@suse.de> +Cc: Horms <horms@verge.net.au> +Cc: Ian Campbell <ian.campbell@xensource.com> +Cc: Magnus Damm <magnus.damm@gmail.com> +Cc: Vivek Goyal <vgoyal@in.ibm.com> +Signed-off-by: Andrew Morton <akpm@linux-foundation.org> +--- + + include/linux/crash_dump.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff -puN include/linux/crash_dump.h~allow-i386-crash-kernels-to-handle-x86_64-dumps-fix include/linux/crash_dump.h +--- a/include/linux/crash_dump.h~allow-i386-crash-kernels-to-handle-x86_64-dumps-fix ++++ a/include/linux/crash_dump.h +@@ -16,7 +16,7 @@ extern struct proc_dir_entry *proc_vmcor + + /* Architecture code defines this if there are other possible ELF + * machine types, e.g. on bi-arch capable hardware. */ +-#ifndef vmcore_elf_check_arch_cross(x) ++#ifndef vmcore_elf_check_arch_cross + #define vmcore_elf_check_arch_cross(x) 0 + #endif + +_ diff --git a/patches/linux-2.6.18/allow-i386-crash-kernels-to-handle-x86_64-dumps.patch b/patches/linux-2.6.18/allow-i386-crash-kernels-to-handle-x86_64-dumps.patch new file mode 100644 index 0000000000..ad9eb93b3b --- /dev/null +++ b/patches/linux-2.6.18/allow-i386-crash-kernels-to-handle-x86_64-dumps.patch @@ -0,0 +1,66 @@ +From: Ian Campbell <ian.campbell@xensource.com> + +The specific case I am encountering is kdump under Xen with a 64 bit +hypervisor and 32 bit kernel/userspace. The dump created is 64 bit due to +the hypervisor but the dump kernel is 32 bit for maximum compatibility. + +It's possibly less likely to be useful in a purely native scenario but I +see no reason to disallow it. + +Signed-off-by: Ian Campbell <ian.campbell@xensource.com> +Acked-by: Vivek Goyal <vgoyal@in.ibm.com> +Cc: Horms <horms@verge.net.au> +Cc: Magnus Damm <magnus.damm@gmail.com> +Cc: "Eric W. Biederman" <ebiederm@xmission.com> +Cc: Andi Kleen <ak@suse.de> +Signed-off-by: Andrew Morton <akpm@linux-foundation.org> +--- + + fs/proc/vmcore.c | 2 +- + include/asm-i386/kexec.h | 3 +++ + include/linux/crash_dump.h | 8 ++++++++ + 3 files changed, 12 insertions(+), 1 deletion(-) + +diff -puN fs/proc/vmcore.c~allow-i386-crash-kernels-to-handle-x86_64-dumps fs/proc/vmcore.c +--- a/fs/proc/vmcore.c~allow-i386-crash-kernels-to-handle-x86_64-dumps ++++ a/fs/proc/vmcore.c +@@ -514,7 +514,7 @@ static int __init parse_crash_elf64_head + /* Do some basic Verification. */ + if (memcmp(ehdr.e_ident, ELFMAG, SELFMAG) != 0 || + (ehdr.e_type != ET_CORE) || +- !elf_check_arch(&ehdr) || ++ !vmcore_elf_check_arch(&ehdr) || + ehdr.e_ident[EI_CLASS] != ELFCLASS64 || + ehdr.e_ident[EI_VERSION] != EV_CURRENT || + ehdr.e_version != EV_CURRENT || +diff -puN include/asm-i386/kexec.h~allow-i386-crash-kernels-to-handle-x86_64-dumps include/asm-i386/kexec.h +--- a/include/asm-i386/kexec.h~allow-i386-crash-kernels-to-handle-x86_64-dumps ++++ a/include/asm-i386/kexec.h +@@ -47,6 +47,9 @@ + /* The native architecture */ + #define KEXEC_ARCH KEXEC_ARCH_386 + ++/* We can also handle crash dumps from 64 bit kernel. */ ++#define vmcore_elf_check_arch_cross(x) ((x)->e_machine == EM_X86_64) ++ + #define MAX_NOTE_BYTES 1024 + + /* CPU does not save ss and esp on stack if execution is already +diff -puN include/linux/crash_dump.h~allow-i386-crash-kernels-to-handle-x86_64-dumps include/linux/crash_dump.h +--- a/include/linux/crash_dump.h~allow-i386-crash-kernels-to-handle-x86_64-dumps ++++ a/include/linux/crash_dump.h +@@ -14,5 +14,13 @@ extern ssize_t copy_oldmem_page(unsigned + extern const struct file_operations proc_vmcore_operations; + extern struct proc_dir_entry *proc_vmcore; + ++/* Architecture code defines this if there are other possible ELF ++ * machine types, e.g. on bi-arch capable hardware. */ ++#ifndef vmcore_elf_check_arch_cross(x) ++#define vmcore_elf_check_arch_cross(x) 0 ++#endif ++ ++#define vmcore_elf_check_arch(x) (elf_check_arch(x) || vmcore_elf_check_arch_cross(x)) ++ + #endif /* CONFIG_CRASH_DUMP */ + #endif /* LINUX_CRASHDUMP_H */ +_ diff --git a/patches/linux-2.6.18/crash-kernel-32-on-64.patch b/patches/linux-2.6.18/crash-kernel-32-on-64.patch deleted file mode 100644 index 8ea9378188..0000000000 --- a/patches/linux-2.6.18/crash-kernel-32-on-64.patch +++ /dev/null @@ -1,11 +0,0 @@ ---- pristine-linux-2.6.18/include/asm-i386/elf.h 2006-09-20 04:42:06.000000000 +0100 -+++ linux-2.6.18-xen/include/asm-i386/elf.h 2007-03-14 16:42:30.000000000 +0000 -@@ -36,7 +36,7 @@ - * This is used to ensure we don't load something for the wrong architecture. - */ - #define elf_check_arch(x) \ -- (((x)->e_machine == EM_386) || ((x)->e_machine == EM_486)) -+ (((x)->e_machine == EM_386) || ((x)->e_machine == EM_486) || ((x)->e_machine == EM_X86_64)) - - /* - * These are used to set parameters in the core dumps. diff --git a/patches/linux-2.6.18/series b/patches/linux-2.6.18/series index 978fdacc42..a3597cd5a0 100644 --- a/patches/linux-2.6.18/series +++ b/patches/linux-2.6.18/series @@ -19,4 +19,5 @@ x86-elfnote-as-preprocessor-macro.patch fixaddr-top.patch git-c06cb8b1c4d25e5b4d7a2d7c2462619de1e0dbc4.patch softlockup-no-idle-hz.patch -crash-kernel-32-on-64.patch +allow-i386-crash-kernels-to-handle-x86_64-dumps.patch +allow-i386-crash-kernels-to-handle-x86_64-dumps-fix.patch |