diff options
| author | Ian Campbell <ian.campbell@citrix.com> | 2010-10-25 18:15:28 +0100 |
|---|---|---|
| committer | Ian Campbell <ian.campbell@citrix.com> | 2010-10-25 18:15:28 +0100 |
| commit | 7f18fb47e5a86772b274fe4811b99f7cf600371b (patch) | |
| tree | 5516e4e0b4afe361d9eabc2048249724d9a5b18d | |
| parent | d47f1a444a67322c291abdc87bd5470e38a16aff (diff) | |
| download | xen-7f18fb47e5a86772b274fe4811b99f7cf600371b.tar.gz xen-7f18fb47e5a86772b274fe4811b99f7cf600371b.tar.bz2 xen-7f18fb47e5a86772b274fe4811b99f7cf600371b.zip | |
libxc: correct handling of switch_qemu_logdirty callback return value
The callback return convention follows xc_domain_save and therefore
returns 0 on success and >0 on error, correct the check accordingly.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
| -rw-r--r-- | tools/libxc/xc_domain_save.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/libxc/xc_domain_save.c b/tools/libxc/xc_domain_save.c index 47f8a79c9d..eee8fb47d2 100644 --- a/tools/libxc/xc_domain_save.c +++ b/tools/libxc/xc_domain_save.c @@ -1015,7 +1015,7 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, uint32_t max_iter } /* Enable qemu-dm logging dirty pages to xen */ - if ( hvm && !callbacks->switch_qemu_logdirty(dom, 1, callbacks->data) ) + if ( hvm && callbacks->switch_qemu_logdirty(dom, 1, callbacks->data) ) { PERROR("Couldn't enable qemu log-dirty mode (errno %d)", errno); goto out; @@ -1879,7 +1879,7 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t dom, uint32_t max_iter XEN_DOMCTL_SHADOW_OP_OFF, NULL, 0, NULL, 0, NULL) < 0 ) DPRINTF("Warning - couldn't disable shadow mode"); - if ( hvm && !callbacks->switch_qemu_logdirty(dom, 0, callbacks->data) ) + if ( hvm && callbacks->switch_qemu_logdirty(dom, 0, callbacks->data) ) DPRINTF("Warning - couldn't disable qemu log-dirty mode"); } |