diff options
author | kfraser@localhost.localdomain <kfraser@localhost.localdomain> | 2007-04-04 19:17:39 +0100 |
---|---|---|
committer | kfraser@localhost.localdomain <kfraser@localhost.localdomain> | 2007-04-04 19:17:39 +0100 |
commit | 79f84ceeb54544278305df540d833ac74709ac4b (patch) | |
tree | a805727675943798cb93f343d6a255b22b33e925 | |
parent | 5967572aaba45da2551f8ad0e79e0b6062f3507d (diff) | |
download | xen-79f84ceeb54544278305df540d833ac74709ac4b.tar.gz xen-79f84ceeb54544278305df540d833ac74709ac4b.tar.bz2 xen-79f84ceeb54544278305df540d833ac74709ac4b.zip |
hvm: local_events_need_delivery() should take notice of EFLAGS.IF.
Signed-off-by: Keir Fraser <keir@xensource.com>
-rw-r--r-- | xen/arch/x86/hvm/irq.c | 19 | ||||
-rw-r--r-- | xen/include/asm-x86/event.h | 7 |
2 files changed, 23 insertions, 3 deletions
diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c index aa531b33fb..a85151eb26 100644 --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -337,6 +337,25 @@ int is_isa_irq_masked(struct vcpu *v, int isa_irq) domain_vioapic(v->domain)->redirtbl[gsi].fields.mask); } +/* + * TODO: 1. Should not need special treatment of event-channel events. + * 2. Should take notice of interrupt shadows (or clear them). + */ +int hvm_local_events_need_delivery(struct vcpu *v) +{ + int pending; + + pending = (vcpu_info(v, evtchn_upcall_pending) || cpu_has_pending_irq(v)); + if ( unlikely(pending) ) + { + struct cpu_user_regs regs; + hvm_store_cpu_guest_regs(v, ®s, NULL); + pending = !irq_masked(regs.eflags); + } + + return pending; +} + #if 0 /* Keep for debugging */ static void irq_dump(struct domain *d) { diff --git a/xen/include/asm-x86/event.h b/xen/include/asm-x86/event.h index 09440bcc4a..32b157b8db 100644 --- a/xen/include/asm-x86/event.h +++ b/xen/include/asm-x86/event.h @@ -35,12 +35,13 @@ static inline void vcpu_mark_events_pending(struct vcpu *v) vcpu_kick(v); } +int hvm_local_events_need_delivery(struct vcpu *v); static inline int local_events_need_delivery(void) { struct vcpu *v = current; - return ((vcpu_info(v, evtchn_upcall_pending) && - !vcpu_info(v, evtchn_upcall_mask)) || - (is_hvm_vcpu(v) && cpu_has_pending_irq(v))); + return (is_hvm_vcpu(v) ? hvm_local_events_need_delivery(v) : + (vcpu_info(v, evtchn_upcall_pending) && + !vcpu_info(v, evtchn_upcall_mask))); } static inline int local_event_delivery_is_enabled(void) |