diff options
| author | Jan Beulich <jbeulich@suse.com> | 2013-05-23 13:08:32 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2013-05-23 13:08:32 +0200 |
| commit | 234c4dde2fd4f1182fe1a6bea6bced83fe363007 (patch) | |
| tree | dc711dc5aba877b21d9b7f3bfd076abd55fc9908 | |
| parent | 9204bc654562976c7cdebf21c6b5013f6e3057b3 (diff) | |
| download | xen-234c4dde2fd4f1182fe1a6bea6bced83fe363007.tar.gz xen-234c4dde2fd4f1182fe1a6bea6bced83fe363007.tar.bz2 xen-234c4dde2fd4f1182fe1a6bea6bced83fe363007.zip | |
x86: fix boot time APIC mode detection
current_cpu_data becomes valid only relatively late in the boot
process, so looking there for a particular feature early in the game
would generally give the appearance of the feature being unavailable.
Getting this wrong means that at kexec time the system would get
returned to xAPIC mode, causing disconnect_bsp_APIC() to try to access
the APIC page, which on systems with x2APIC pre-enabled will never get
set up.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
| -rw-r--r-- | xen/arch/x86/apic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c index b28f5ed431..a52a0e881d 100644 --- a/xen/arch/x86/apic.c +++ b/xen/arch/x86/apic.c @@ -1474,7 +1474,7 @@ enum apic_mode current_local_apic_mode(void) /* Reading EXTD bit from the MSR is only valid if CPUID * says so, else reserved */ - if ( cpu_has(¤t_cpu_data, X86_FEATURE_X2APIC) + if ( boot_cpu_has(X86_FEATURE_X2APIC) && (msr_contents & MSR_IA32_APICBASE_EXTD) ) return APIC_MODE_X2APIC; |