1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
|
From c9a1f4547556a531c4fd61ccde08391ec0ad390c Mon Sep 17 00:00:00 2001
From: Michael Zoran <mzoran@crowfest.net>
Date: Sat, 14 Jan 2017 21:33:51 -0800
Subject: [PATCH 102/454] ARM64/DWC_OTG: Port dwc_otg driver to ARM64
In ARM64, the FIQ mechanism used by this driver is not current
implemented. As a workaround, reqular IRQ is used instead
of FIQ.
In a separate change, the IRQ-CPU mapping is round robined
on ARM64 to increase concurrency and allow multiple interrupts
to be serviced at a time. This reduces the need for FIQ.
Tests Run:
This mechanism is most likely to break when multiple USB devices
are attached at the same time. So the system was tested under
stress.
Devices:
1. USB Speakers playing back a FLAC audio through VLC
at 96KHz.(Higher then typically, but supported on my speakers).
2. sftp transferring large files through the buildin ethernet
connection which is connected through USB.
3. Keyboard and mouse attached and being used.
Although I do occasionally hear some glitches, the music seems to
play quite well.
Signed-off-by: Michael Zoran <mzoran@crowfest.net>
---
drivers/usb/host/dwc_otg/Makefile | 3 +
drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.c | 17 +++++
drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.h | 24 +++++++
drivers/usb/host/dwc_otg/dwc_otg_hcd.c | 4 ++
drivers/usb/host/dwc_otg/dwc_otg_hcd_if.h | 4 ++
drivers/usb/host/dwc_otg/dwc_otg_hcd_intr.c | 3 +-
drivers/usb/host/dwc_otg/dwc_otg_hcd_linux.c | 72 ++++++++++++++++++++
drivers/usb/host/dwc_otg/dwc_otg_os_dep.h | 2 +
8 files changed, 128 insertions(+), 1 deletion(-)
--- a/drivers/usb/host/dwc_otg/Makefile
+++ b/drivers/usb/host/dwc_otg/Makefile
@@ -37,7 +37,10 @@ dwc_otg-objs += dwc_otg_pcd_linux.o dwc_
dwc_otg-objs += dwc_otg_hcd.o dwc_otg_hcd_linux.o dwc_otg_hcd_intr.o dwc_otg_hcd_queue.o dwc_otg_hcd_ddma.o
dwc_otg-objs += dwc_otg_adp.o
dwc_otg-objs += dwc_otg_fiq_fsm.o
+ifneq ($(CONFIG_ARM64),y)
dwc_otg-objs += dwc_otg_fiq_stub.o
+endif
+
ifneq ($(CFI),)
dwc_otg-objs += dwc_otg_cfi.o
endif
--- a/drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.c
+++ b/drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.c
@@ -74,6 +74,21 @@ void notrace _fiq_print(enum fiq_debug_l
}
}
+
+#ifdef CONFIG_ARM64
+
+inline void fiq_fsm_spin_lock(fiq_lock_t *lock)
+{
+ spin_lock((spinlock_t *)lock);
+}
+
+inline void fiq_fsm_spin_unlock(fiq_lock_t *lock)
+{
+ spin_unlock((spinlock_t *)lock);
+}
+
+#else
+
/**
* fiq_fsm_spin_lock() - ARMv6+ bare bones spinlock
* Must be called with local interrupts and FIQ disabled.
@@ -121,6 +136,8 @@ inline void fiq_fsm_spin_unlock(fiq_lock
inline void fiq_fsm_spin_unlock(fiq_lock_t *lock) { }
#endif
+#endif
+
/**
* fiq_fsm_restart_channel() - Poke channel enable bit for a split transaction
* @channel: channel to re-enable
--- a/drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.h
+++ b/drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.h
@@ -127,6 +127,12 @@ enum fiq_debug_level {
FIQDBG_PORTHUB = (1 << 3),
};
+#ifdef CONFIG_ARM64
+
+typedef spinlock_t fiq_lock_t;
+
+#else
+
typedef struct {
union {
uint32_t slock;
@@ -137,6 +143,8 @@ typedef struct {
};
} fiq_lock_t;
+#endif
+
struct fiq_state;
extern void _fiq_print (enum fiq_debug_level dbg_lvl, volatile struct fiq_state *state, char *fmt, ...);
@@ -357,6 +365,22 @@ struct fiq_state {
struct fiq_channel_state channel[0];
};
+#ifdef CONFIG_ARM64
+
+#ifdef local_fiq_enable
+#undef local_fiq_enable
+#endif
+
+#ifdef local_fiq_disable
+#undef local_fiq_disable
+#endif
+
+extern void local_fiq_enable(void);
+
+extern void local_fiq_disable(void);
+
+#endif
+
extern void fiq_fsm_spin_lock(fiq_lock_t *lock);
extern void fiq_fsm_spin_unlock(fiq_lock_t *lock);
--- a/drivers/usb/host/dwc_otg/dwc_otg_hcd.c
+++ b/drivers/usb/host/dwc_otg/dwc_otg_hcd.c
@@ -1000,6 +1000,10 @@ int dwc_otg_hcd_init(dwc_otg_hcd_t * hcd
}
DWC_MEMSET(hcd->fiq_state, 0, (sizeof(struct fiq_state) + (sizeof(struct fiq_channel_state) * num_channels)));
+#ifdef CONFIG_ARM64
+ spin_lock_init(&hcd->fiq_state->lock);
+#endif
+
for (i = 0; i < num_channels; i++) {
hcd->fiq_state->channel[i].fsm = FIQ_PASSTHROUGH;
}
--- a/drivers/usb/host/dwc_otg/dwc_otg_hcd_if.h
+++ b/drivers/usb/host/dwc_otg/dwc_otg_hcd_if.h
@@ -116,7 +116,11 @@ extern int32_t dwc_otg_hcd_handle_intr(d
/** This function is used to handle the fast interrupt
*
*/
+#ifdef CONFIG_ARM64
+extern void dwc_otg_hcd_handle_fiq(void);
+#else
extern void __attribute__ ((naked)) dwc_otg_hcd_handle_fiq(void);
+#endif
/**
* Returns private data set by
--- a/drivers/usb/host/dwc_otg/dwc_otg_hcd_intr.c
+++ b/drivers/usb/host/dwc_otg/dwc_otg_hcd_intr.c
@@ -36,8 +36,9 @@
#include "dwc_otg_regs.h"
#include <linux/jiffies.h>
+#ifdef CONFIG_ARM
#include <asm/fiq.h>
-
+#endif
extern bool microframe_schedule;
--- a/drivers/usb/host/dwc_otg/dwc_otg_hcd_linux.c
+++ b/drivers/usb/host/dwc_otg/dwc_otg_hcd_linux.c
@@ -51,7 +51,9 @@
#include <linux/dma-mapping.h>
#include <linux/version.h>
#include <asm/io.h>
+#ifdef CONFIG_ARM
#include <asm/fiq.h>
+#endif
#include <linux/usb.h>
#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,35)
#include <../drivers/usb/core/hcd.h>
@@ -71,6 +73,13 @@
#include "dwc_otg_driver.h"
#include "dwc_otg_hcd.h"
+#ifndef __virt_to_bus
+#define __virt_to_bus __virt_to_phys
+#define __bus_to_virt __phys_to_virt
+#define __pfn_to_bus(x) __pfn_to_phys(x)
+#define __bus_to_pfn(x) __phys_to_pfn(x)
+#endif
+
extern unsigned char _dwc_otg_fiq_stub, _dwc_otg_fiq_stub_end;
/**
@@ -395,14 +404,49 @@ static struct dwc_otg_hcd_function_ops h
.get_b_hnp_enable = _get_b_hnp_enable,
};
+#ifdef CONFIG_ARM64
+
+static int simfiq_irq = -1;
+
+void local_fiq_enable(void)
+{
+ if (simfiq_irq >= 0)
+ enable_irq(simfiq_irq);
+}
+
+void local_fiq_disable(void)
+{
+ if (simfiq_irq >= 0)
+ disable_irq(simfiq_irq);
+}
+
+irqreturn_t fiq_irq_handler(int irq, void *dev_id)
+{
+ dwc_otg_hcd_t *dwc_otg_hcd = (dwc_otg_hcd_t *)dev_id;
+
+ if (fiq_fsm_enable)
+ dwc_otg_fiq_fsm(dwc_otg_hcd->fiq_state, dwc_otg_hcd->core_if->core_params->host_channels);
+ else
+ dwc_otg_fiq_nop(dwc_otg_hcd->fiq_state);
+
+ return IRQ_HANDLED;
+}
+
+#else
static struct fiq_handler fh = {
.name = "usb_fiq",
};
+#endif
+
static void hcd_init_fiq(void *cookie)
{
dwc_otg_device_t *otg_dev = cookie;
dwc_otg_hcd_t *dwc_otg_hcd = otg_dev->hcd;
+#ifdef CONFIG_ARM64
+ int retval = 0;
+ int irq;
+#else
struct pt_regs regs;
int irq;
@@ -430,6 +474,7 @@ static void hcd_init_fiq(void *cookie)
// __show_regs(®s);
set_fiq_regs(®s);
+#endif
//Set the mphi periph to the required registers
dwc_otg_hcd->fiq_state->mphi_regs.base = otg_dev->os_dep.mphi_base;
@@ -448,6 +493,23 @@ static void hcd_init_fiq(void *cookie)
DWC_WARN("MPHI periph has NOT been enabled");
#endif
// Enable FIQ interrupt from USB peripheral
+#ifdef CONFIG_ARM64
+ irq = platform_get_irq(otg_dev->os_dep.platformdev, 1);
+
+ if (irq < 0) {
+ DWC_ERROR("Can't get SIM-FIQ irq");
+ return;
+ }
+
+ retval = request_irq(irq, fiq_irq_handler, 0, "dwc_otg_sim-fiq", dwc_otg_hcd);
+
+ if (retval < 0) {
+ DWC_ERROR("Unable to request SIM-FIQ irq\n");
+ return;
+ }
+
+ simfiq_irq = irq;
+#else
#ifdef CONFIG_MULTI_IRQ_HANDLER
irq = platform_get_irq(otg_dev->os_dep.platformdev, 1);
#else
@@ -459,6 +521,8 @@ static void hcd_init_fiq(void *cookie)
}
enable_fiq(irq);
local_fiq_enable();
+#endif
+
}
/**
@@ -521,6 +585,13 @@ int hcd_init(dwc_bus_dev_t *_dev)
otg_dev->hcd = dwc_otg_hcd;
otg_dev->hcd->otg_dev = otg_dev;
+#ifdef CONFIG_ARM64
+ if (dwc_otg_hcd_init(dwc_otg_hcd, otg_dev->core_if))
+ goto error2;
+
+ if (fiq_enable)
+ hcd_init_fiq(otg_dev);
+#else
if (dwc_otg_hcd_init(dwc_otg_hcd, otg_dev->core_if)) {
goto error2;
}
@@ -533,6 +604,7 @@ int hcd_init(dwc_bus_dev_t *_dev)
smp_call_function_single(0, hcd_init_fiq, otg_dev, 1);
}
}
+#endif
hcd->self.otg_port = dwc_otg_hcd_otg_port(dwc_otg_hcd);
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,33) //don't support for LM(with 2.6.20.1 kernel)
--- a/drivers/usb/host/dwc_otg/dwc_otg_os_dep.h
+++ b/drivers/usb/host/dwc_otg/dwc_otg_os_dep.h
@@ -76,8 +76,10 @@
#ifdef PLATFORM_INTERFACE
#include <linux/platform_device.h>
+#ifdef CONFIG_ARM
#include <asm/mach/map.h>
#endif
+#endif
/** The OS page size */
#define DWC_OS_PAGE_SIZE PAGE_SIZE
|