1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
|
From 659037c028f28ac0f13bd54a55c6c81761fb02ce Mon Sep 17 00:00:00 2001
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
Date: Mon, 22 Nov 2021 12:31:35 +0000
Subject: [PATCH] media: i2c: ov5647: Add support for regulator
control.
The driver supported using GPIOs to control the shutdown line,
but no regulator control.
Add regulator hooks.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
drivers/media/i2c/ov5647.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
--- a/drivers/media/i2c/ov5647.c
+++ b/drivers/media/i2c/ov5647.c
@@ -20,6 +20,7 @@
#include <linux/module.h>
#include <linux/of_graph.h>
#include <linux/pm_runtime.h>
+#include <linux/regulator/consumer.h>
#include <linux/slab.h>
#include <linux/videodev2.h>
#include <media/v4l2-ctrls.h>
@@ -82,6 +83,15 @@
#define OV5647_EXPOSURE_DEFAULT 1000
#define OV5647_EXPOSURE_MAX 65535
+/* regulator supplies */
+static const char * const ov5647_supply_names[] = {
+ "avdd", /* Analog power */
+ "dovdd", /* Digital I/O power */
+ "dvdd", /* Digital core power */
+};
+
+#define OV5647_NUM_SUPPLIES ARRAY_SIZE(ov5647_supply_names)
+
struct regval_list {
u16 addr;
u8 data;
@@ -103,6 +113,7 @@ struct ov5647 {
struct mutex lock;
struct clk *xclk;
struct gpio_desc *pwdn;
+ struct regulator_bulk_data supplies[OV5647_NUM_SUPPLIES];
bool clock_ncont;
struct v4l2_ctrl_handler ctrls;
const struct ov5647_mode *mode;
@@ -787,6 +798,12 @@ static int ov5647_power_on(struct device
dev_dbg(dev, "OV5647 power on\n");
+ ret = regulator_bulk_enable(OV5647_NUM_SUPPLIES, sensor->supplies);
+ if (ret < 0) {
+ dev_err(dev, "Failed to enable regulators\n");
+ return ret;
+ }
+
if (sensor->pwdn) {
gpiod_set_value_cansleep(sensor->pwdn, 0);
msleep(PWDN_ACTIVE_DELAY_MS);
@@ -818,6 +835,7 @@ error_clk_disable:
clk_disable_unprepare(sensor->xclk);
error_pwdn:
gpiod_set_value_cansleep(sensor->pwdn, 1);
+ regulator_bulk_disable(OV5647_NUM_SUPPLIES, sensor->supplies);
return ret;
}
@@ -847,6 +865,7 @@ static int ov5647_power_off(struct devic
clk_disable_unprepare(sensor->xclk);
gpiod_set_value_cansleep(sensor->pwdn, 1);
+ regulator_bulk_disable(OV5647_NUM_SUPPLIES, sensor->supplies);
return 0;
}
@@ -1347,6 +1366,18 @@ static const struct v4l2_ctrl_ops ov5647
.s_ctrl = ov5647_s_ctrl,
};
+static int ov5647_configure_regulators(struct device *dev,
+ struct ov5647 *sensor)
+{
+ unsigned int i;
+
+ for (i = 0; i < OV5647_NUM_SUPPLIES; i++)
+ sensor->supplies[i].supply = ov5647_supply_names[i];
+
+ return devm_regulator_bulk_get(dev, OV5647_NUM_SUPPLIES,
+ sensor->supplies);
+}
+
static int ov5647_init_controls(struct ov5647 *sensor, struct device *dev)
{
struct i2c_client *client = v4l2_get_subdevdata(&sensor->sd);
@@ -1494,6 +1525,12 @@ static int ov5647_probe(struct i2c_clien
return -EINVAL;
}
+ ret = ov5647_configure_regulators(dev, sensor);
+ if (ret) {
+ dev_err(dev, "Failed to get power regulators\n");
+ return ret;
+ }
+
mutex_init(&sensor->lock);
sensor->mode = OV5647_DEFAULT_MODE;
|