aboutsummaryrefslogtreecommitdiffstats
path: root/package/utils/nvram
diff options
context:
space:
mode:
authorZhai Zhaoxuan <zhaizhaoxuan@xiaomi.com>2017-07-11 18:12:00 +0800
committerJohn Crispin <john@phrozen.org>2017-11-15 21:11:23 +0100
commitc382237ac33a787043b22abc42f0c5a80278baae (patch)
treefc0553354472e334095473b14f4b2e0374823449 /package/utils/nvram
parent2dca7177e75d2b910ace883e08cbadcaa050666f (diff)
downloadupstream-c382237ac33a787043b22abc42f0c5a80278baae.tar.gz
upstream-c382237ac33a787043b22abc42f0c5a80278baae.tar.bz2
upstream-c382237ac33a787043b22abc42f0c5a80278baae.zip
packages: nvram: fix memory leak in _nvram_free
The value of nvram_tuple_t is allocated in _nvram_realloc, but it is not freed in _nvram_free. Signed-off-by: Zhai Zhaoxuan <zhaizhaoxuan@xiaomi.com>
Diffstat (limited to 'package/utils/nvram')
-rw-r--r--package/utils/nvram/src/nvram.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/package/utils/nvram/src/nvram.c b/package/utils/nvram/src/nvram.c
index ca89392107..d5e12ee69a 100644
--- a/package/utils/nvram/src/nvram.c
+++ b/package/utils/nvram/src/nvram.c
@@ -47,6 +47,8 @@ static void _nvram_free(nvram_handle_t *h)
for (i = 0; i < NVRAM_ARRAYSIZE(h->nvram_hash); i++) {
for (t = h->nvram_hash[i]; t; t = next) {
next = t->next;
+ if (t->value)
+ free(t->value);
free(t);
}
h->nvram_hash[i] = NULL;
@@ -55,6 +57,8 @@ static void _nvram_free(nvram_handle_t *h)
/* Free dead table */
for (t = h->nvram_dead; t; t = next) {
next = t->next;
+ if (t->value)
+ free(t->value);
free(t);
}