diff options
author | Rosen Penev <rosenp@gmail.com> | 2019-08-31 18:50:48 -0700 |
---|---|---|
committer | Stijn Tintel <stijn@linux-ipv6.be> | 2020-05-08 03:32:52 +0300 |
commit | 73fa1aba94f5cf566007ac18cee3ef08b3ae64bc (patch) | |
tree | 12d94da20915031cd34260409e6355c8e05b66b7 /package/network/services/samba36/patches/270-remove_registry_backend.patch | |
parent | 79da9d78b98e1cd4574a37e2c4c5f8315b91563d (diff) | |
download | upstream-73fa1aba94f5cf566007ac18cee3ef08b3ae64bc.tar.gz upstream-73fa1aba94f5cf566007ac18cee3ef08b3ae64bc.tar.bz2 upstream-73fa1aba94f5cf566007ac18cee3ef08b3ae64bc.zip |
samba36: Remove
Samba 3.6 is completely unsupported, in addition to having tons of patches
It also causes kernel panics on some platforms when sendfile is enabled.
Example:
https://github.com/gnubee-git/GnuBee_Docs/issues/45
I have reproduced on ramips as well as mvebu in the past.
Samba 4 is an alternative available in the packages repo.
cifsd is a lightweight alternative available in the packages repo. It is
also a faster alternative to both Samba versions (lower CPU usage). It
was renamed to ksmbd.
To summarize, here are the alternatives:
- ksmbd + luci-app-cifsd
- samba4 + luci-app-samba4
Signed-off-by: Rosen Penev <rosenp@gmail.com>
[drop samba36-server from GEMINI_NAS_PACKAGES, ksmbd rename + summary]
Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
Diffstat (limited to 'package/network/services/samba36/patches/270-remove_registry_backend.patch')
-rw-r--r-- | package/network/services/samba36/patches/270-remove_registry_backend.patch | 43 |
1 files changed, 0 insertions, 43 deletions
diff --git a/package/network/services/samba36/patches/270-remove_registry_backend.patch b/package/network/services/samba36/patches/270-remove_registry_backend.patch deleted file mode 100644 index 147b1cec74..0000000000 --- a/package/network/services/samba36/patches/270-remove_registry_backend.patch +++ /dev/null @@ -1,43 +0,0 @@ ---- a/source3/lib/smbconf/smbconf_init.c -+++ b/source3/lib/smbconf/smbconf_init.c -@@ -68,9 +68,12 @@ sbcErr smbconf_init(TALLOC_CTX *mem_ctx, - } - } - -+#ifdef REGISTRY_BACKEND - if (strequal(backend, "registry") || strequal(backend, "reg")) { - err = smbconf_init_reg(mem_ctx, conf_ctx, path); -- } else if (strequal(backend, "file") || strequal(backend, "txt")) { -+ } else -+#endif -+ if (strequal(backend, "file") || strequal(backend, "txt")) { - err = smbconf_init_txt(mem_ctx, conf_ctx, path); - } else if (sep == NULL) { - /* ---- a/source3/lib/netapi/serverinfo.c -+++ b/source3/lib/netapi/serverinfo.c -@@ -557,7 +557,10 @@ static WERROR NetServerSetInfo_l_1005(st - return WERR_INVALID_PARAM; - } - -- if (!lp_config_backend_is_registry()) { -+#ifdef REGISTRY_BACKEND -+ if (!lp_config_backend_is_registry()) -+#endif -+ { - libnetapi_set_error_string(ctx, - "Configuration manipulation requested but not " - "supported by backend"); ---- a/source3/smbd/server.c -+++ b/source3/smbd/server.c -@@ -1230,8 +1230,10 @@ extern void build_options(bool screen); - exit(1); - } - -+#ifdef REGISTRY_BACKEND - if (!W_ERROR_IS_OK(registry_init_full())) - exit(1); -+#endif - - /* Open the share_info.tdb here, so we don't have to open - after the fork on every single connection. This is a small |